-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for validator transactions #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly comments around the commented out test, as well as why is the ?
changed to | null
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm. A comment around a new not working commented out test - a bit confused around it
Also, please update changelog. And fix lint
Description
In release 1.10 a new transaction type 'validator_transaction' was added. This adds its corresponding response type. Fixed a few type bugs as well.
Example
Test Plan
Added a static test against a sample JSON response to make sure the response satisfies the type.
Perhaps later make this a runtime check against 'live' data but then we'd have to write/generate our own runtime type check.
Note the user_transaction test doesn't pass because of the single sender API issues.
Related Links