Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to generate testing transactions #518

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Sep 20, 2024

Description

linear task: https://linear.app/aptoslabs/issue/EI-521/export-generated-jsons-to-processors-repo-without-cargo-dependency

THe way we import new transactions when we are testing, we have to create a PR every time we generate new transaction JSONs to be used in the processor tests. This allows us to skip that step.

Previous Steps

  1. generate txn jsons in aptos-core repo
  2. create a pr
  3. copy commit hash and paste it into processor repo
  4. write test cases

New Steps

  1. generate txn jsons in aptos-core repo (you would have to specify the output folder to the folder in processor repo here (e.g. aptos-indexer-processor/rust/testing-transactions/json_transactions/ ).
  2. write test cases

Test Plan

used the new txn generated from this change and tests still pass
Screenshot 2024-09-20 at 2 22 20 PM

Screenshot 2024-09-20 at 2 22 23 PM

…ocessor testing. This enables us to skip creating a pr whenever there is new transaction to test with.
@yuunlimm yuunlimm requested review from larry-aptos and a team September 20, 2024 21:23
@yuunlimm yuunlimm force-pushed the yuunlimm/processor-testing-import branch from 8d092e8 to 62d4df1 Compare September 20, 2024 21:48
@yuunlimm yuunlimm force-pushed the yuunlimm/processor-testing-import branch from 62d4df1 to 797790f Compare September 20, 2024 22:05
Copy link
Collaborator

@larry-aptos larry-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the existing crate under aptos-core and we move here. looks good.

@larry-aptos
Copy link
Collaborator

Can you link the linear ticket here? i think we have a task tracking this effort. thanks!

@yuunlimm yuunlimm merged commit e53f4da into main Sep 23, 2024
7 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/processor-testing-import branch September 23, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants