Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip updating processor status with null values for timestamp #511

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

yuunlimm
Copy link
Contributor

Test Plan

Tested with parquet_ans_processor
when there is no transaction processed, log and do not update.
Screenshot 2024-09-16 at 12 59 15 PM
Screenshot 2024-09-16 at 12 59 13 PM

when there is transaction processed, update the processor status
Screenshot 2024-09-16 at 1 06 04 PM

@yuunlimm yuunlimm requested review from a team and larry-aptos September 16, 2024 20:09
@larry-aptos
Copy link
Collaborator

nit fix lint.

for existing records, will have it null until next time there are transaction processed I assume

@yuunlimm
Copy link
Contributor Author

nit fix lint.

for existing records, will have it null until next time there are transaction processed I assume

yes that's correct!

@yuunlimm yuunlimm merged commit c42d401 into main Sep 17, 2024
7 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/processor-status branch September 17, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants