Fix the indexer metrics with nullable timestamp. #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @larry-aptos and the rest of your teammates on |
larry-aptos
force-pushed
the
09-16-fix_the_indexer_metrics_with_nullable_timestamp
branch
from
a816d07
to
86718c4
Compare
just-in-chang
approved these changes
Sep 16, 2024
dermanyang
approved these changes
Sep 16, 2024
rtso
approved these changes
Sep 16, 2024
yuunlimm
approved these changes
Sep 16, 2024
larry-aptos
force-pushed
the
09-16-fix_the_indexer_metrics_with_nullable_timestamp
branch
from
86718c4
to
b0c4587
Compare
|
For some reason this doesn't get merged... trying now. |
larry-aptos
force-pushed
the
09-16-fix_the_indexer_metrics_with_nullable_timestamp
branch
from
b0c4587
to
3ddfd37
Compare
larry-aptos
deleted the
09-16-fix_the_indexer_metrics_with_nullable_timestamp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^
Root cause: some parquet tables don't have this value updated.
Testing plan
Added both unit tests to cover the null and non-null cases.