add parquet_token_v2_processor #462
Conversation
yuunlimm
force-pushed
the
yuunlimm/parquet-token-processor
branch
2 times, most recently
from
c1793b4
to
7f41600
Compare
| pub mutable_uri: Option<bool>, | ||
| pub table_handle_v1: Option<String>, | ||
| pub token_standard: String, | ||
| #[allocative(skip)] |
There was a problem hiding this comment.
we used to also have a collection_properties field
There was a problem hiding this comment.
collections is not going to be migrated over in this phase. we can ignore this file for now
| pub token_properties: String, | ||
| pub description: String, | ||
| pub token_standard: String, | ||
| pub is_fungible_v2: Option<bool>, |
There was a problem hiding this comment.
@rtso what's the diff between token_standard and is_fungible_v2?
There was a problem hiding this comment.
token_standard is whether the token is v1 or v2. is_fungible_v2 is whether this token is also fungible (it's an implementation detail based on the contract)
collection_data wasn't a part of parquet. do we need in bq? |
yuunlimm
force-pushed
the
yuunlimm/parquet-token-processor
branch
from
7f41600
to
bc247ca
Compare
yuunlimm
force-pushed
the
yuunlimm/parquet-token-processor
branch
from
bc247ca
to
684b30f
Compare
|
|
yuunlimm
force-pushed
the
yuunlimm/parquet-token-processor
branch
from
a83c973
to
26370b8
Compare
yuunlimm
force-pushed
the
yuunlimm/parquet-token-processor
branch
from
26370b8
to
206e088
Compare
| property_version_v1: 0, | ||
| owner_address: Some(owner_address.clone()), | ||
| storage_id: storage_id.clone(), | ||
| amount: "0".to_string(), |
There was a problem hiding this comment.
nit: make 0 as constant, it's hard to understand why this is 0 without context.
There was a problem hiding this comment.
sounds good. will also add a comment
| // set to negative of event index to avoid collison with write set index | ||
| write_set_change_index: -1 * event_index, | ||
| token_data_id: token_data_id.clone(), | ||
| property_version_v1: 0, |
There was a problem hiding this comment.
something like LEGACY_DEFAULT_PROPERTY_VERSION would help.. btw, is it due to v1 migration?
There was a problem hiding this comment.
not quite sure if it was added as a part of migration.
yuunlimm
force-pushed
the
yuunlimm/parquet-token-processor
branch
from
d189d84
to
4f55d77
Compare
Description
Add parquet token processor that is responsible for
1. collection_v2this will be omitted for now.2. token_datas_v2
3. token_ownerships_v2
Test Plan
token_ownerships
collection_v2
