Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPU profiling support. #336

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add CPU profiling support. #336

merged 1 commit into from
Apr 22, 2024

Conversation

grao1991
Copy link
Contributor

@grao1991 grao1991 commented Mar 29, 2024 •
edited
Loading

Serves the CPU flamegraph at "host:health_check_port/profilez" page.

It took 10s to collect samples, and you will see the flamegraph afterwards.

@grao1991 grao1991 changed the title Add profiling support. Add CPU profiling support. Mar 29, 2024
@grao1991 grao1991 force-pushed the grao_profiling branch 4 times, most recently from 7656cba to 7bcd8ad Compare April 2, 2024 19:23
@grao1991 grao1991 force-pushed the grao_profiling branch 4 times, most recently from 24c3c5f to 5efb889 Compare April 19, 2024 18:43
CapCap
CapCap approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@CapCap CapCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux only? LGTM, but please add PR description and ideally link to the "how to use
notion

@grao1991 grao1991 merged commit b6a3035 into main Apr 22, 2024
8 checks passed
@grao1991 grao1991 deleted the grao_profiling branch April 22, 2024 23:11
@grao1991
Copy link
Contributor Author

Linux only? LGTM, but please add PR description and ideally link to the "how to use notion

Link added..

I'm too lazy to figure out a way for non-linux :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larry-aptos larry-aptos larry-aptos approved these changes

@CapCap CapCap CapCap approved these changes

@rtso rtso Awaiting requested review from rtso

@bowenyang007 bowenyang007 Awaiting requested review from bowenyang007

@just-in-chang just-in-chang Awaiting requested review from just-in-chang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grao1991 @CapCap @larry-aptos