[TS SDK] Add support to filter on coin data query #9773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
changed the title
movekevin
reviewed
Aug 25, 2023
| @@ -830,19 +831,17 @@ export class IndexerClient { | |||
| extraArgs?: { | |||
| options?: IndexerPaginationArgs; | |||
| orderBy?: IndexerSortBy<Current_Fungible_Asset_Balances_Order_By>[]; | |||
| filter?: [Current_Fungible_Asset_Balances_Bool_Exp]; | |||
There was a problem hiding this comment.
I think we need to default to filtering out secondary stores. Otherwise the fungible_asset_client also needs to be rewritten to allow transferring/checking balances from secondary stores. Currently no operations regarding secondary stores are supported. This means developers can run into a very weird experience here:
- They call check getAccountCoinsData, which returns secondary stores
- They sum up the balances and display to the users which now show balances > what they have in primary stores
- They try to send > what they have in primary store => Errors
- Everyone is now confused. Users are confused that they have less money than what wallets show them. Developers are confused why things error out
|
This issue is stale because it has been open 45 days with no activity. Remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the user to filter on the coin data query as some products might want to exclude secondary stores data until better ecosystem support.
#9747 (comment)
Test Plan