-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHA] Remove non-required GHA jobs and migrate to new flows. #9535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLind
changed the title
[GHA] Remove non-required GHA jobs.
[GHA] Remove non-required GHA jobs and migrate to new flows.
Aug 7, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ibalajiarun
approved these changes
Aug 8, 2023
perryjrandall
approved these changes
Aug 8, 2023
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the now non-required GHA jobs from the
lint-test.yaml
flow. The jobs that are removed in this PR have been replaced by the new (required) GHA flows:general-lints
,rust-lints
,rust-smoke-tests
,rust-unit-tests
. The benefit of this is that these jobs use the new GHA determinator, so they will become no-ops on docs only changes. 😄 Likewise, we can continue to extend the determinator to improve PR flows.Note: in order for this to land, we need to modify the branch protection rules for the
main
branch:scripts-lint
,ecosystem-lint
,ecosystem-python-lint
,rust-lint
,rust-doc-test
,rust-unit-test
,rust-smoke-test
andcheck-vm-features
.general-lints
,rust-lints
,rust-smoke-tests
andrust-unit-tests
.Test Plan
Existing test infrastructure.