Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Remove non-required GHA jobs and migrate to new flows. #9535

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

JoshLind
Copy link
Contributor

@JoshLind JoshLind commented Aug 7, 2023

Description

This PR removes the now non-required GHA jobs from the lint-test.yaml flow. The jobs that are removed in this PR have been replaced by the new (required) GHA flows: general-lints, rust-lints, rust-smoke-tests, rust-unit-tests. The benefit of this is that these jobs use the new GHA determinator, so they will become no-ops on docs only changes. 😄 Likewise, we can continue to extend the determinator to improve PR flows.

Note: in order for this to land, we need to modify the branch protection rules for the main branch:

  1. Remove these jobs from the main branch protection: scripts-lint, ecosystem-lint, ecosystem-python-lint, rust-lint, rust-doc-test, rust-unit-test, rust-smoke-test and check-vm-features.
  2. Add these jobs to the main branch protection: general-lints, rust-lints, rust-smoke-tests and rust-unit-tests.

Test Plan

Existing test infrastructure.

@JoshLind JoshLind requested review from a team as code owners August 7, 2023 22:47
@JoshLind JoshLind changed the title [GHA] Remove non-required GHA jobs. [GHA] Remove non-required GHA jobs and migrate to new flows. Aug 7, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite compat success on aptos-node-v1.5.1 ==> 797a7a17da54add15cbb23f4a5016c845d4547d8

Compatibility test results for aptos-node-v1.5.1 ==> 797a7a17da54add15cbb23f4a5016c845d4547d8 (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4464 txn/s, latency: 7363 ms, (p50: 6600 ms, p90: 10100 ms, p99: 19000 ms), latency samples: 174120
2. Upgrading first Validator to new version: 797a7a17da54add15cbb23f4a5016c845d4547d8
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1856 txn/s, latency: 15798 ms, (p50: 18600 ms, p90: 22100 ms, p99: 22300 ms), latency samples: 92800
3. Upgrading rest of first batch to new version: 797a7a17da54add15cbb23f4a5016c845d4547d8
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1624 txn/s, latency: 15674 ms, (p50: 19400 ms, p90: 21900 ms, p99: 22300 ms), latency samples: 92620
4. upgrading second batch to new version: 797a7a17da54add15cbb23f4a5016c845d4547d8
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3172 txn/s, latency: 9484 ms, (p50: 10200 ms, p90: 12700 ms, p99: 13300 ms), latency samples: 136400
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 797a7a17da54add15cbb23f4a5016c845d4547d8 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite realistic_env_max_load success on 797a7a17da54add15cbb23f4a5016c845d4547d8

two traffics test: inner traffic : committed: 6045 txn/s, latency: 6449 ms, (p50: 6100 ms, p90: 8400 ms, p99: 11700 ms), latency samples: 2629640
two traffics test : committed: 100 txn/s, latency: 3077 ms, (p50: 3000 ms, p90: 3600 ms, p99: 6300 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.279, avg: 0.219", "QsPosToProposal: max: 0.167, avg: 0.158", "ConsensusProposalToOrdered: max: 0.673, avg: 0.643", "ConsensusOrderedToCommit: max: 0.631, avg: 0.584", "ConsensusProposalToCommit: max: 1.296, avg: 1.227"]
Max round gap was 1 [limit 4] at version 1364262. Max no progress secs was 3.637689 [limit 10] at version 1364262.
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 797a7a17da54add15cbb23f4a5016c845d4547d8

Compatibility test results for aptos-node-v1.5.1 ==> 797a7a17da54add15cbb23f4a5016c845d4547d8 (PR)
Upgrade the nodes to version: 797a7a17da54add15cbb23f4a5016c845d4547d8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4518 txn/s, latency: 7217 ms, (p50: 7500 ms, p90: 9900 ms, p99: 14400 ms), latency samples: 167180
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 797a7a17da54add15cbb23f4a5016c845d4547d8 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants