Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-builder] Make release builder use a relative path for raw script #9530

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

perryjrandall
Copy link
Contributor

Currently this absolute path only works from within a docker image

This change makes the path relative and possible to run from elsewhere

Test Plan:

RUST_BACKTRACE=1 cargo run --profile performance -p aptos-release-builder \
    generate-proposals \
    --release-config aptos-move/aptos-release-builder/data/release.yaml --output-dir banana

Pull Request: #9529

@perryjrandall perryjrandall added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Aug 7, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@perryjrandall perryjrandall force-pushed the perry-relative-framework-main branch from 4d7f765 to a617891 Compare August 8, 2023 00:17
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@perryjrandall perryjrandall enabled auto-merge (rebase) August 8, 2023 00:42
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@perryjrandall perryjrandall force-pushed the perry-relative-framework-main branch from a617891 to 120fae4 Compare August 8, 2023 01:49
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ript

Currently this absolute path only works from within a docker image

This change makes the path relative and possible to run from elsewhere

Test Plan:
```
RUST_BACKTRACE=1 cargo run --profile performance -p aptos-release-builder \
    generate-proposals \
    --release-config aptos-move/aptos-release-builder/data/release.yaml --output-dir banana
```

Pull Request: #9529
@perryjrandall perryjrandall force-pushed the perry-relative-framework-main branch from 120fae4 to 13ef7f8 Compare August 8, 2023 14:46
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite compat success on aptos-node-v1.5.1 ==> 13ef7f89fd9132a2f306c5d144f0c8750834bddf

Compatibility test results for aptos-node-v1.5.1 ==> 13ef7f89fd9132a2f306c5d144f0c8750834bddf (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4546 txn/s, latency: 7145 ms, (p50: 7200 ms, p90: 10000 ms, p99: 14100 ms), latency samples: 172780
2. Upgrading first Validator to new version: 13ef7f89fd9132a2f306c5d144f0c8750834bddf
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1771 txn/s, latency: 16075 ms, (p50: 19200 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 92140
3. Upgrading rest of first batch to new version: 13ef7f89fd9132a2f306c5d144f0c8750834bddf
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1822 txn/s, latency: 15883 ms, (p50: 18600 ms, p90: 22200 ms, p99: 22300 ms), latency samples: 92940
4. upgrading second batch to new version: 13ef7f89fd9132a2f306c5d144f0c8750834bddf
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3371 txn/s, latency: 9367 ms, (p50: 10200 ms, p90: 13200 ms, p99: 13800 ms), latency samples: 134840
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 13ef7f89fd9132a2f306c5d144f0c8750834bddf passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite realistic_env_max_load success on 13ef7f89fd9132a2f306c5d144f0c8750834bddf

two traffics test: inner traffic : committed: 6092 txn/s, latency: 6422 ms, (p50: 6000 ms, p90: 8100 ms, p99: 12300 ms), latency samples: 2644300
two traffics test : committed: 100 txn/s, latency: 3017 ms, (p50: 3000 ms, p90: 3500 ms, p99: 7400 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.216, avg: 0.211", "QsPosToProposal: max: 0.199, avg: 0.166", "ConsensusProposalToOrdered: max: 0.650, avg: 0.624", "ConsensusOrderedToCommit: max: 0.597, avg: 0.552", "ConsensusProposalToCommit: max: 1.229, avg: 1.176"]
Max round gap was 1 [limit 4] at version 1296669. Max no progress secs was 3.809701 [limit 10] at version 1296669.
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 13ef7f89fd9132a2f306c5d144f0c8750834bddf

Compatibility test results for aptos-node-v1.5.1 ==> 13ef7f89fd9132a2f306c5d144f0c8750834bddf (PR)
Upgrade the nodes to version: 13ef7f89fd9132a2f306c5d144f0c8750834bddf
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4373 txn/s, latency: 7334 ms, (p50: 7800 ms, p90: 10200 ms, p99: 12300 ms), latency samples: 166180
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 13ef7f89fd9132a2f306c5d144f0c8750834bddf passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants