Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools] vscode workspace settings #9527

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

ibalajiarun
Copy link
Contributor

Description

This PR introduces some default vscode settings to make it easier to work on the aptos-core repo using vscode.

Test Plan

N/A

@ibalajiarun ibalajiarun requested review from a team and geekflyer August 7, 2023 19:28
@ibalajiarun ibalajiarun enabled auto-merge (squash) August 7, 2023 22:03
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

✅ Forge suite compat success on aptos-node-v1.5.1 ==> bfeac9a3e7656bbaf0019130269976542b7478f0

Compatibility test results for aptos-node-v1.5.1 ==> bfeac9a3e7656bbaf0019130269976542b7478f0 (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4334 txn/s, latency: 6648 ms, (p50: 6600 ms, p90: 9300 ms, p99: 12600 ms), latency samples: 182040
2. Upgrading first Validator to new version: bfeac9a3e7656bbaf0019130269976542b7478f0
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1775 txn/s, latency: 16112 ms, (p50: 19200 ms, p90: 22100 ms, p99: 22500 ms), latency samples: 92340
3. Upgrading rest of first batch to new version: bfeac9a3e7656bbaf0019130269976542b7478f0
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1782 txn/s, latency: 16411 ms, (p50: 19000 ms, p90: 22300 ms, p99: 22500 ms), latency samples: 92700
4. upgrading second batch to new version: bfeac9a3e7656bbaf0019130269976542b7478f0
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3078 txn/s, latency: 10044 ms, (p50: 10600 ms, p90: 13800 ms, p99: 14200 ms), latency samples: 126220
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> bfeac9a3e7656bbaf0019130269976542b7478f0 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> bfeac9a3e7656bbaf0019130269976542b7478f0

Compatibility test results for aptos-node-v1.5.1 ==> bfeac9a3e7656bbaf0019130269976542b7478f0 (PR)
Upgrade the nodes to version: bfeac9a3e7656bbaf0019130269976542b7478f0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4917 txn/s, latency: 6673 ms, (p50: 6600 ms, p90: 10100 ms, p99: 12100 ms), latency samples: 181960
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> bfeac9a3e7656bbaf0019130269976542b7478f0 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

✅ Forge suite realistic_env_max_load success on bfeac9a3e7656bbaf0019130269976542b7478f0

two traffics test: inner traffic : committed: 6163 txn/s, latency: 6347 ms, (p50: 6000 ms, p90: 8100 ms, p99: 12100 ms), latency samples: 2674960
two traffics test : committed: 100 txn/s, latency: 3003 ms, (p50: 2900 ms, p90: 3600 ms, p99: 7100 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.215, avg: 0.209", "QsPosToProposal: max: 0.165, avg: 0.151", "ConsensusProposalToOrdered: max: 0.637, avg: 0.613", "ConsensusOrderedToCommit: max: 0.524, avg: 0.498", "ConsensusProposalToCommit: max: 1.159, avg: 1.111"]
Max round gap was 1 [limit 4] at version 651256. Max no progress secs was 3.979288 [limit 10] at version 2570202.
Test Ok

@ibalajiarun ibalajiarun merged commit 1e8ecb3 into main Aug 7, 2023
@ibalajiarun ibalajiarun deleted the balaji/vscode-settings branch August 7, 2023 23:33
xbtmatt pushed a commit that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants