Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gha] cargo metadata uploader #9487

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[gha] cargo metadata uploader #9487

merged 1 commit into from
Aug 8, 2023

Conversation

ibalajiarun
Copy link
Contributor

@ibalajiarun ibalajiarun commented Aug 4, 2023

Description

This PR introduces a new workflow that generate a cargo metadata json file and uploads it to a GCS bucket. The metadata will be used for target determinator CLI.

Test Plan

GHA checks runs fine.

@ibalajiarun ibalajiarun force-pushed the balaji/cargo-metadata branch 8 times, most recently from e873012 to c3be636 Compare August 4, 2023 03:46
@ibalajiarun ibalajiarun marked this pull request as ready for review August 4, 2023 03:48
@ibalajiarun ibalajiarun requested review from a team as code owners August 4, 2023 03:48
@ibalajiarun ibalajiarun requested a review from geekflyer August 4, 2023 03:48
@ibalajiarun ibalajiarun force-pushed the balaji/cargo-metadata branch from c3be636 to 45cafec Compare August 4, 2023 03:48
METADATA_FILENAME="metadata-${{ github.sha }}.json"
cargo metadata --all-features > ${METADATA_FILENAME}
echo "Uploading ${METADATA_FILENAME}..."
gsutil cp ${METADATA_FILENAME} gs://aptos-core-cargo-metadata-public/${METADATA_FILENAME}
Copy link
Contributor

@geekflyer geekflyer Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do this kinda in 1 line without writing an intermediate file:

Suggested change
gsutil cp ${METADATA_FILENAME} gs://aptos-core-cargo-metadata-public/${METADATA_FILENAME}
cargo metadata --all-features | gsutil cp - gs://aptos-core-cargo-metadata-public/metadata-${{ github.sha }}.json

@ibalajiarun ibalajiarun force-pushed the balaji/cargo-metadata branch from 45cafec to 84e9e40 Compare August 8, 2023 14:59
@ibalajiarun ibalajiarun enabled auto-merge (squash) August 8, 2023 15:03
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite compat success on aptos-node-v1.5.1 ==> 84e9e401e57276d1423ebbee541899bf143395a5

Compatibility test results for aptos-node-v1.5.1 ==> 84e9e401e57276d1423ebbee541899bf143395a5 (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4261 txn/s, latency: 6945 ms, (p50: 6700 ms, p90: 9300 ms, p99: 13500 ms), latency samples: 178980
2. Upgrading first Validator to new version: 84e9e401e57276d1423ebbee541899bf143395a5
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1744 txn/s, latency: 15706 ms, (p50: 19200 ms, p90: 22000 ms, p99: 23100 ms), latency samples: 92440
3. Upgrading rest of first batch to new version: 84e9e401e57276d1423ebbee541899bf143395a5
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1714 txn/s, latency: 16510 ms, (p50: 19200 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 89140
4. upgrading second batch to new version: 84e9e401e57276d1423ebbee541899bf143395a5
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2232 txn/s, latency: 9578 ms, (p50: 10000 ms, p90: 13300 ms, p99: 14400 ms), latency samples: 140620
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 84e9e401e57276d1423ebbee541899bf143395a5 passed
Test Ok

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 84e9e401e57276d1423ebbee541899bf143395a5

Compatibility test results for aptos-node-v1.5.1 ==> 84e9e401e57276d1423ebbee541899bf143395a5 (PR)
Upgrade the nodes to version: 84e9e401e57276d1423ebbee541899bf143395a5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4649 txn/s, latency: 6984 ms, (p50: 7500 ms, p90: 9900 ms, p99: 11700 ms), latency samples: 172040
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 84e9e401e57276d1423ebbee541899bf143395a5 passed
Test Ok

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

✅ Forge suite realistic_env_max_load success on 84e9e401e57276d1423ebbee541899bf143395a5

two traffics test: inner traffic : committed: 6738 txn/s, latency: 5809 ms, (p50: 5700 ms, p90: 7200 ms, p99: 10500 ms), latency samples: 2917980
two traffics test : committed: 100 txn/s, latency: 3027 ms, (p50: 2900 ms, p90: 3600 ms, p99: 5100 ms), latency samples: 1900
Max round gap was 1 [limit 4] at version 1356313. Max no progress secs was 3.530895 [limit 10] at version 1356313.
Test Ok

@ibalajiarun ibalajiarun merged commit 67fba59 into main Aug 8, 2023
@ibalajiarun ibalajiarun deleted the balaji/cargo-metadata branch August 8, 2023 16:02
xbtmatt pushed a commit that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants