Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFT Metadata Crawler] DB migrations in code #9451

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

just-in-chang
Copy link
Contributor

Description

Run DB migrations in code instead of as a command

Copy link
Contributor

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@just-in-chang just-in-chang enabled auto-merge (squash) August 3, 2023 04:18
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

✅ Forge suite compat success on aptos-node-v1.5.1 ==> a2c1208b021f7bdd9eabde9b07a532b22c4a96f5

Compatibility test results for aptos-node-v1.5.1 ==> a2c1208b021f7bdd9eabde9b07a532b22c4a96f5 (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4709 txn/s, latency: 6597 ms, (p50: 6600 ms, p90: 10100 ms, p99: 11200 ms), latency samples: 183660
2. Upgrading first Validator to new version: a2c1208b021f7bdd9eabde9b07a532b22c4a96f5
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1766 txn/s, latency: 15918 ms, (p50: 19300 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 91880
3. Upgrading rest of first batch to new version: a2c1208b021f7bdd9eabde9b07a532b22c4a96f5
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1780 txn/s, latency: 16045 ms, (p50: 19200 ms, p90: 22200 ms, p99: 22600 ms), latency samples: 92560
4. upgrading second batch to new version: a2c1208b021f7bdd9eabde9b07a532b22c4a96f5
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3094 txn/s, latency: 9634 ms, (p50: 10400 ms, p90: 12800 ms, p99: 14100 ms), latency samples: 136140
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> a2c1208b021f7bdd9eabde9b07a532b22c4a96f5 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

✅ Forge suite realistic_env_max_load success on a2c1208b021f7bdd9eabde9b07a532b22c4a96f5

two traffics test: inner traffic : committed: 6404 txn/s, latency: 6114 ms, (p50: 6000 ms, p90: 7800 ms, p99: 11400 ms), latency samples: 2779500
two traffics test : committed: 100 txn/s, latency: 3049 ms, (p50: 2900 ms, p90: 3800 ms, p99: 4900 ms), latency samples: 1820
Max round gap was 1 [limit 4] at version 1390944. Max no progress secs was 3.570451 [limit 10] at version 1390944.
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> a2c1208b021f7bdd9eabde9b07a532b22c4a96f5

Compatibility test results for aptos-node-v1.5.1 ==> a2c1208b021f7bdd9eabde9b07a532b22c4a96f5 (PR)
Upgrade the nodes to version: a2c1208b021f7bdd9eabde9b07a532b22c4a96f5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4514 txn/s, latency: 7256 ms, (p50: 7400 ms, p90: 9900 ms, p99: 13500 ms), latency samples: 167020
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> a2c1208b021f7bdd9eabde9b07a532b22c4a96f5 passed
Test Ok

@just-in-chang just-in-chang merged commit 8fe69b2 into main Aug 3, 2023
@just-in-chang just-in-chang deleted the justin/migration-in-code branch August 3, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants