-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Update build_cli_release.ps1 to include openssl #9447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmigo
force-pushed
the
jin/add_openssl_on_windows_cli_build
branch
from
August 3, 2023 00:57
b032087
to
3e8ffc4
Compare
gregnazario
reviewed
Aug 3, 2023
scripts/cli/build_cli_release.ps1
Outdated
Comment on lines
19
to
26
# Note: This is required to bypass openssl isssue on Windows. | ||
echo "Setting up vcpkg" | ||
echo "VCPKG_ROOT=$VCPKG_ROOT" | Out-File -FilePath $env:GITHUB_ENV -Append | ||
vcpkg install openssl:x64-windows-static-md --clean-after-build | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, this actually should solve the problem how I did it let me see if I can involve it in a new build
0xmigo
force-pushed
the
jin/add_openssl_on_windows_cli_build
branch
from
August 3, 2023 21:55
3e8ffc4
to
1ec8b59
Compare
JoshLind
reviewed
Aug 3, 2023
0xmigo
force-pushed
the
jin/add_openssl_on_windows_cli_build
branch
2 times, most recently
from
August 3, 2023 23:56
8fbcea9
to
07b4ddc
Compare
0xmigo
force-pushed
the
jin/add_openssl_on_windows_cli_build
branch
from
August 4, 2023 00:45
07b4ddc
to
b38a34b
Compare
gregnazario
approved these changes
Aug 4, 2023
0xmaayan
approved these changes
Aug 4, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the build script to make sure
openssl
install correctly. Otherwise we will see the following error when running the windows builderror: failed to run custom build command for
openssl-sys v0.9.85
Test Plan
Did a dry run and make sure it build successfully
https://github.com/aptos-labs/aptos-core/actions/runs/5757104296