Refer to create rather than create_from_account for token v2

[banool]

Description

The docs refer to create_from_account but this function is deprecated, so I make them refer to create instead.

Additionally, create_from_account is marked as deprecated but nothing says what to use instead. I add a comment explaining what to do.

As you can see my editor also obliterates trailing spaces, hopefully that's alright. We should probably make the linter do that anyway.

Test Plan

👀

[movekevin]

Lets hold off on this a bit as this is not enabled on testnet and mainnet yet

[banool]

Got it, I'll add a label.

[xbtmatt]

I brought this up with Kevin already but yeah we may need to think more about how the new create_object is going to be inserted into contracts bc 1. it makes objects even harder to track, especially in terms of when it's invoked by a contract that's built around using GUIDs, but also importantly 2. because it will break a few tests in some of the token examples that assume a GUID is being used to create an object.

[davidiw]

2. because it will break a few tests in some of the token examples that assume a GUID is being used to create an object.

@xbtmatt can you enumerate those? I updated the Python example to use events, it wasn't too bad.

[xbtmatt]

2. because it will break a few tests in some of the token examples that assume a GUID is being used to create an object.

@xbtmatt can you enumerate those? I updated the Python example to use events, it wasn't too bad.

I thought there were more but maybe not :p

These are the only two I could find, in @gregnazario's test_utils module for the marketplace contract

aptos-core/aptos-move/move-examples/marketplace/sources/test_utils.move

Lines 90 to 101 in 59f6293

	aptos_token::mint(
	seller,
	collection_name,
	string::utf8(b"description"),
	string::utf8(b"token_name"),
	string::utf8(b"uri"),
	vector::empty(),
	vector::empty(),
	vector::empty(),
	);
	let obj_addr = object::create_guid_object_address(seller_addr, token_creation_num);

aptos-core/aptos-move/move-examples/marketplace/sources/test_utils.move

Lines 110 to 121 in 59f6293

	aptos_token::mint(
	seller,
	collection_name,
	string::utf8(b"description"),
	string::utf8(b"token_name_2"),
	string::utf8(b"uri"),
	vector::empty(),
	vector::empty(),
	vector::empty(),
	);
	let obj_addr = object::create_guid_object_address(seller_addr, token_creation_num);

Although they will obviously not fail in certain environments, like for the CLI they won't until it uses the release that enables the auid feature flag

[davidiw]

now is the time!

[davidiw]

Gah there are other conflicts...

[davidiw]

@banool please update and we'll land...

[github-actions]

✅ Forge suite compat success on aptos-node-v1.7.2 ==> 1a39fa2efe16c551279d70229184ed5a5e7a6afb

Compatibility test results for aptos-node-v1.7.2 ==> 1a39fa2efe16c551279d70229184ed5a5e7a6afb (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.2
compatibility::simple-validator-upgrade::liveness-check : committed: 3476 txn/s, latency: 6022 ms, (p50: 5100 ms, p90: 9300 ms, p99: 20600 ms), latency samples: 208580
2. Upgrading first Validator to new version: 1a39fa2efe16c551279d70229184ed5a5e7a6afb
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1780 txn/s, latency: 16203 ms, (p50: 19200 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92600
3. Upgrading rest of first batch to new version: 1a39fa2efe16c551279d70229184ed5a5e7a6afb
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1696 txn/s, latency: 15712 ms, (p50: 19100 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 89900
4. upgrading second batch to new version: 1a39fa2efe16c551279d70229184ed5a5e7a6afb
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3600 txn/s, latency: 8760 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12800 ms), latency samples: 144000
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> 1a39fa2efe16c551279d70229184ed5a5e7a6afb passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 1a39fa2efe16c551279d70229184ed5a5e7a6afb

two traffics test: inner traffic : committed: 8040 txn/s, latency: 4882 ms, (p50: 4800 ms, p90: 5700 ms, p99: 9900 ms), latency samples: 3473500
two traffics test : committed: 100 txn/s, latency: 2181 ms, (p50: 2100 ms, p90: 2700 ms, p99: 6100 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.214, avg: 0.199", "QsPosToProposal: max: 0.169, avg: 0.151", "ConsensusProposalToOrdered: max: 0.616, avg: 0.597", "ConsensusOrderedToCommit: max: 0.514, avg: 0.492", "ConsensusProposalToCommit: max: 1.124, avg: 1.089"]
Max round gap was 1 [limit 4] at version 1612428. Max no progress secs was 4.242273 [limit 10] at version 1612428.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on aptos-node-v1.7.2 ==> 1a39fa2efe16c551279d70229184ed5a5e7a6afb

Compatibility test results for aptos-node-v1.7.2 ==> 1a39fa2efe16c551279d70229184ed5a5e7a6afb (PR)
Upgrade the nodes to version: 1a39fa2efe16c551279d70229184ed5a5e7a6afb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4033 txn/s, latency: 4950 ms, (p50: 4800 ms, p90: 8000 ms, p99: 8500 ms), latency samples: 242000
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> 1a39fa2efe16c551279d70229184ed5a5e7a6afb passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking