Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] charge MutBorrowFieldGeneric properly #9420

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

wlawt
Copy link
Contributor

@wlawt wlawt commented Aug 2, 2023

Description

This closes #9419

Note: this doesn't need to be feature gated because MutBorrowFieldGeneric cost have always been the same as cost for MutBorrowField.

@vgao1996 vgao1996 enabled auto-merge (squash) August 2, 2023 00:47
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

✅ Forge suite compat success on aptos-node-v1.5.1 ==> bdd557528537fb44c2bf9a610221186982d598ee

Compatibility test results for aptos-node-v1.5.1 ==> bdd557528537fb44c2bf9a610221186982d598ee (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4742 txn/s, latency: 6918 ms, (p50: 6600 ms, p90: 10400 ms, p99: 11700 ms), latency samples: 189700
2. Upgrading first Validator to new version: bdd557528537fb44c2bf9a610221186982d598ee
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1784 txn/s, latency: 16107 ms, (p50: 19300 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 92800
3. Upgrading rest of first batch to new version: bdd557528537fb44c2bf9a610221186982d598ee
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1844 txn/s, latency: 15695 ms, (p50: 19200 ms, p90: 22200 ms, p99: 22600 ms), latency samples: 92240
4. upgrading second batch to new version: bdd557528537fb44c2bf9a610221186982d598ee
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3270 txn/s, latency: 9530 ms, (p50: 10100 ms, p90: 13700 ms, p99: 14100 ms), latency samples: 140640
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> bdd557528537fb44c2bf9a610221186982d598ee passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

✅ Forge suite realistic_env_max_load success on bdd557528537fb44c2bf9a610221186982d598ee

two traffics test: inner traffic : committed: 6541 txn/s, latency: 5993 ms, (p50: 5700 ms, p90: 7500 ms, p99: 10500 ms), latency samples: 2832620
two traffics test : committed: 100 txn/s, latency: 3118 ms, (p50: 3000 ms, p90: 3700 ms, p99: 6300 ms), latency samples: 1800
Max round gap was 1 [limit 4] at version 1520012. Max no progress secs was 3.721633 [limit 10] at version 1520012.
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> bdd557528537fb44c2bf9a610221186982d598ee

Compatibility test results for aptos-node-v1.5.1 ==> bdd557528537fb44c2bf9a610221186982d598ee (PR)
Upgrade the nodes to version: bdd557528537fb44c2bf9a610221186982d598ee
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4473 txn/s, latency: 7345 ms, (p50: 7800 ms, p90: 10200 ms, p99: 10800 ms), latency samples: 165520
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> bdd557528537fb44c2bf9a610221186982d598ee passed
Test Ok

@vgao1996 vgao1996 merged commit 7a608f9 into aptos-labs:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Charge MutBorrowFieldGeneric properly
3 participants