[State Sync] Ensure fast sync doesn't exit early.

[JoshLind]

WIP.

Description

Test Plan

[github-actions]

✅ Forge suite compat success on aptos-node-v1.5.1 ==> f13097d5ffec15b30af9e890abfa232099f2bddd

Compatibility test results for aptos-node-v1.5.1 ==> f13097d5ffec15b30af9e890abfa232099f2bddd (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 3928 txn/s, latency: 7093 ms, (p50: 6300 ms, p90: 10200 ms, p99: 24700 ms), latency samples: 172840
2. Upgrading first Validator to new version: f13097d5ffec15b30af9e890abfa232099f2bddd
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1785 txn/s, latency: 16434 ms, (p50: 19000 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92860
3. Upgrading rest of first batch to new version: f13097d5ffec15b30af9e890abfa232099f2bddd
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1777 txn/s, latency: 15972 ms, (p50: 19000 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 92440
4. upgrading second batch to new version: f13097d5ffec15b30af9e890abfa232099f2bddd
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2996 txn/s, latency: 9807 ms, (p50: 10200 ms, p90: 12600 ms, p99: 14000 ms), latency samples: 125840
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> f13097d5ffec15b30af9e890abfa232099f2bddd passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on f13097d5ffec15b30af9e890abfa232099f2bddd

two traffics test: inner traffic : committed: 6473 txn/s, latency: 6052 ms, (p50: 5700 ms, p90: 7500 ms, p99: 10800 ms), latency samples: 2802940
two traffics test : committed: 100 txn/s, latency: 3057 ms, (p50: 3000 ms, p90: 3600 ms, p99: 5700 ms), latency samples: 1740
Max round gap was 1 [limit 4] at version 953293. Max no progress secs was 3.5457501 [limit 10] at version 953293.
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> f13097d5ffec15b30af9e890abfa232099f2bddd

Compatibility test results for aptos-node-v1.5.1 ==> f13097d5ffec15b30af9e890abfa232099f2bddd (PR)
Upgrade the nodes to version: f13097d5ffec15b30af9e890abfa232099f2bddd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2929 txn/s, latency: 7563 ms, (p50: 7200 ms, p90: 10800 ms, p99: 20000 ms), latency samples: 161120
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> f13097d5ffec15b30af9e890abfa232099f2bddd passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[JoshLind]

Closing this out as it should hopefully not be needed.