[move-compiler v2] Comparison testing for file-format generator

[wrwg]

This extends the transactional-test-runner to support compiler V2 and to do comparison testing between V1 and V2.

It ports over most of the transactional tests of the V1 compiler into the V2 tree and runs comparison testing on them, fixing bugs throughout the compilation chain as needed.

Closes #9334

NOTE: this is diffbased on #9258; only look at the latest commit.

[vgao1996]

I assume you'll fix these failed tests at a later stage, right?

[wrwg]

Yes! #9343

[github-actions]

✅ Forge suite compat success on aptos-node-v1.5.1 ==> 9a3664783caa01ac7a03095f71f6fd209cd8a2fc

Compatibility test results for aptos-node-v1.5.1 ==> 9a3664783caa01ac7a03095f71f6fd209cd8a2fc (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4903 txn/s, latency: 6725 ms, (p50: 6600 ms, p90: 9300 ms, p99: 13600 ms), latency samples: 196140
2. Upgrading first Validator to new version: 9a3664783caa01ac7a03095f71f6fd209cd8a2fc
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1880 txn/s, latency: 15499 ms, (p50: 19700 ms, p90: 21800 ms, p99: 22300 ms), latency samples: 92140
3. Upgrading rest of first batch to new version: 9a3664783caa01ac7a03095f71f6fd209cd8a2fc
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1841 txn/s, latency: 15671 ms, (p50: 19100 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 92060
4. upgrading second batch to new version: 9a3664783caa01ac7a03095f71f6fd209cd8a2fc
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3366 txn/s, latency: 9447 ms, (p50: 10000 ms, p90: 13600 ms, p99: 14200 ms), latency samples: 138040
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 9a3664783caa01ac7a03095f71f6fd209cd8a2fc passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 9a3664783caa01ac7a03095f71f6fd209cd8a2fc

two traffics test: inner traffic : committed: 5973 txn/s, latency: 6334 ms, (p50: 6000 ms, p90: 8100 ms, p99: 11000 ms), latency samples: 2676259
two traffics test : committed: 100 txn/s, latency: 3054 ms, (p50: 2900 ms, p90: 3800 ms, p99: 7200 ms), latency samples: 1800
Max round gap was 1 [limit 4] at version 1289996. Max no progress secs was 3.792645 [limit 10] at version 1289996.
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 9a3664783caa01ac7a03095f71f6fd209cd8a2fc

Compatibility test results for aptos-node-v1.5.1 ==> 9a3664783caa01ac7a03095f71f6fd209cd8a2fc (PR)
Upgrade the nodes to version: 9a3664783caa01ac7a03095f71f6fd209cd8a2fc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2961 txn/s, latency: 7321 ms, (p50: 7800 ms, p90: 10500 ms, p99: 11800 ms), latency samples: 165840
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 9a3664783caa01ac7a03095f71f6fd209cd8a2fc passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[brmataptos]

Hopefully someone looked at the tests better than I.

[brmataptos]

This is kind of redundant with the code above, but I can't simplify it much in Rust, so it's fine as is. Higher-order functions in Rust are a bit verbose.

Here's a try:

pub fn format_diff_no_color(expected: impl AsRef<str>, actual: impl AsRef<str>) -> String {
    format_diff_shared(
        expected,
        actual,
        |x: &String, ret: &mut String| {
            ret.push_str(&format!("= {}", x.replace('\n', "\n= ")));
            ret.push('\n');
        },
        |x: &String, ret: &mut String| {
            ret.push_str(&format!("+ {}", x.replace('\n', "\n+ ")));
            ret.push('\n');
        },
        |x: &String, ret: &mut String| {
            ret.push_str(&format!("- {}", x.replace('\n', "\n- ")));
            ret.push('\n');
        },
    )
}

Where the code above is changed to:

fn format_diff_shared(
    expected: impl AsRef<str>,
    actual: impl AsRef<str>,
    same_proc: impl Fn(&String, &mut String),
    add_proc: impl Fn(&String, &mut String),
    rem_proc: impl Fn(&String, &mut String),
) -> String {
    use difference::{Changeset, Difference};

    let changeset = Changeset::new(expected.as_ref(), actual.as_ref(), "\n");

    let mut ret = String::new();

    for seq in changeset.diffs {
        match &seq {
            Difference::Same(x) => {
                same_proc(x, &mut ret);
            },
            Difference::Add(x) => {
                add_proc(x, &mut ret);
            },
            Difference::Rem(x) => {
                rem_proc(x, &mut ret);
            },
        }
    }
    ret
}

pub fn format_diff(expected: impl AsRef<str>, actual: impl AsRef<str>) -> String {
    format_diff_shared(
        expected,
        actual,
        |x: &String, ret: &mut String| {
            ret.push_str(x);
            ret.push('\n');
        },
        |x: &String, ret: &mut String| {
            ret.push_str("\x1B[92m");
            ret.push_str(x);
            ret.push_str("\x1B[0m");
            ret.push('\n');
        },
        |x: &String, ret: &mut String| {
            ret.push_str("\x1B[91m");
            ret.push_str(x);
            ret.push_str("\x1B[0m");
            ret.push('\n');
        },
    )
}

[brmataptos]

It looks like you're pushing twice if you happen to have something on the stack. Shouldn't this be:

if self.stack.len() != 0 {
    self.abstract_flush_stack(ctx, 0);
}
self.abstract_push_args(ctx, result.as_ref());