[TS SDK] Support contentType in request #8977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
force-pushed
the
add_mediaType_to_request
branch
from
1917b23 to
bb5c716
Compare
0xmaayan
changed the title
0xmigo
reviewed
Jul 6, 2023
| expect(true).toBe(false); | ||
| } | ||
| }, | ||
| longTestTimeout, |
There was a problem hiding this comment.
Curious, why do we include a longTestTimeout on every test now?
There was a problem hiding this comment.
it is flaky on how much time it takes for the test to complete, if you notice we use it on most of the tests we just didn't have it on this file
| endpoint: "transactions", | ||
| body: bcsTxn, | ||
| originMethod: "test request includes all headers", | ||
| mediaType: "application/x.aptos.signed_transaction+bcs", |
There was a problem hiding this comment.
I see, so when the request is a bcs serialized txn, the content type need to be set to application/x.aptos.signed_transaction+bcs? Hmm not sure if I seen this in Python nor Rust sdk
There was a problem hiding this comment.
interesting.... we should have it, without it API explodes lol
There was a problem hiding this comment.
banool
requested changes
Jul 6, 2023
| @@ -26,12 +26,14 @@ async function axiosRequest<Request, Response>( | |||
| url: string, | |||
| method: "GET" | "POST", | |||
| body?: Request, | |||
| mediaType?: string, | |||
There was a problem hiding this comment.
Let's call it contentType instead, since that's the actual header we're using.
0xmigo
approved these changes
Jul 6, 2023
banool
approved these changes
Jul 6, 2023
0xmaayan
force-pushed
the
add_mediaType_to_request
branch
from
bb5c716 to
9666466
Compare
0xmaayan
changed the title
0xmaayan
force-pushed
the
add_mediaType_to_request
branch
from
9666466 to
96f08ae
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation overrides existing
'content-type':'application/x.aptos.signed_transaction+bcs'header when passing in custom headers.This PR adds
contentTypesupport that when submitting a transaction, the expected content type would be set.more context here https://aptos-org.slack.com/archives/C04D0LSBVJN/p1688610023758839
Test Plan
tests are passing
added specific test https://github.com/aptos-labs/aptos-core/compare/add_mediaType_to_request?expand=1#diff-9187cd50043dfc9d3829abdb7a919d2497b633279daa100db09194b2d6509366R45