[Forge] Small fix to sanitize_forge_resource_name.

[JoshLind]

Description

Note: This is required to unblock a currently failing forge test.

This PR fixes a small issue in the sanitize_forge_resource_name function. Specifically, it's possible for the forge namespace to end in a - (after sanitization), which is not valid. This PR extends the function and adds some new tests.

Test Plan

New unit tests.

[rustielin]

Thanks for fixing this + adding tests!

[github-actions]

✅ Forge suite compat success on aptos-node-v1.4.4 ==> 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7

Compatibility test results for aptos-node-v1.4.4 ==> 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7 (PR)
1. Check liveness of validators at old version: aptos-node-v1.4.4
compatibility::simple-validator-upgrade::liveness-check : committed: 6922 txn/s, latency: 4788 ms, (p50: 4700 ms, p90: 6500 ms, p99: 8000 ms), latency samples: 235360
2. Upgrading first Validator to new version: 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4081 txn/s, latency: 7894 ms, (p50: 8400 ms, p90: 10300 ms, p99: 10900 ms), latency samples: 155100
3. Upgrading rest of first batch to new version: 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4325 txn/s, latency: 7185 ms, (p50: 7900 ms, p90: 8900 ms, p99: 9700 ms), latency samples: 168680
4. upgrading second batch to new version: 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6243 txn/s, latency: 5266 ms, (p50: 5300 ms, p90: 7200 ms, p99: 8500 ms), latency samples: 218520
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7

two traffics test: inner traffic : committed: 6001 txn/s, latency: 6494 ms, (p50: 6400 ms, p90: 7800 ms, p99: 11200 ms), latency samples: 2604800
two traffics test : committed: 100 txn/s, latency: 2588 ms, (p50: 2500 ms, p90: 2900 ms, p99: 4500 ms), latency samples: 1780
Max round gap was 1 [limit 4] at version 1320540. Max no progress secs was 3.574722 [limit 10] at version 1320540.
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on aptos-node-v1.4.4 ==> 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7

Compatibility test results for aptos-node-v1.4.4 ==> 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7 (PR)
Upgrade the nodes to version: 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4646 txn/s, latency: 7057 ms, (p50: 7500 ms, p90: 9900 ms, p99: 15300 ms), latency samples: 171920
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> 37d532a8d7f6ffb6c3d0bfb03f812beddf5fb1f7 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking