Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gas Estimation] enable #8801

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[Gas Estimation] enable #8801

merged 1 commit into from
Jun 23, 2023

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented Jun 22, 2023

Description

Enable gas estimation as default, so the updated estimation is deployed in prod on the next release.

@bchocho bchocho requested a review from banool June 23, 2023 16:02
@bchocho bchocho marked this pull request as ready for review June 23, 2023 16:02
Copy link
Contributor

@JoshLind JoshLind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@bchocho bchocho force-pushed the brian/gas-estimation-on branch from 7716385 to 0eba650 Compare June 23, 2023 17:33
@bchocho bchocho enabled auto-merge (squash) June 23, 2023 17:35
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.4.4 ==> 0eba650db8765ba66175b1aaf8388c6e93961e21

Compatibility test results for aptos-node-v1.4.4 ==> 0eba650db8765ba66175b1aaf8388c6e93961e21 (PR)
1. Check liveness of validators at old version: aptos-node-v1.4.4
compatibility::simple-validator-upgrade::liveness-check : committed: 6360 txn/s, latency: 5042 ms, (p50: 5100 ms, p90: 8000 ms, p99: 10300 ms), latency samples: 241700
2. Upgrading first Validator to new version: 0eba650db8765ba66175b1aaf8388c6e93961e21
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3705 txn/s, latency: 8443 ms, (p50: 8700 ms, p90: 9800 ms, p99: 11000 ms), latency samples: 144520
3. Upgrading rest of first batch to new version: 0eba650db8765ba66175b1aaf8388c6e93961e21
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4118 txn/s, latency: 7797 ms, (p50: 9000 ms, p90: 10000 ms, p99: 10500 ms), latency samples: 160640
4. upgrading second batch to new version: 0eba650db8765ba66175b1aaf8388c6e93961e21
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6403 txn/s, latency: 5145 ms, (p50: 5100 ms, p90: 7700 ms, p99: 9400 ms), latency samples: 236920
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> 0eba650db8765ba66175b1aaf8388c6e93961e21 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 0eba650db8765ba66175b1aaf8388c6e93961e21

performance benchmark : committed: 5674 txn/s, latency: 7001 ms, (p50: 5700 ms, p90: 10300 ms, p99: 26800 ms), latency samples: 2422940
Max round gap was 2 [limit 4] at version 2175988. Max no progress secs was 4.675052 [limit 10] at version 2175988.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.4.4 ==> 0eba650db8765ba66175b1aaf8388c6e93961e21

Compatibility test results for aptos-node-v1.4.4 ==> 0eba650db8765ba66175b1aaf8388c6e93961e21 (PR)
Upgrade the nodes to version: 0eba650db8765ba66175b1aaf8388c6e93961e21
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4860 txn/s, latency: 6523 ms, (p50: 6600 ms, p90: 9600 ms, p99: 10200 ms), latency samples: 184680
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> 0eba650db8765ba66175b1aaf8388c6e93961e21 passed
Test Ok

@bchocho bchocho merged commit c5d2fdf into main Jun 23, 2023
@bchocho bchocho deleted the brian/gas-estimation-on branch June 23, 2023 22:36
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
### Description

Enable gas estimation as default, so the updated estimation is deployed in prod on the next release.
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
### Description

Enable gas estimation as default, so the updated estimation is deployed in prod on the next release.
gedigi pushed a commit that referenced this pull request Aug 2, 2023
### Description

Enable gas estimation as default, so the updated estimation is deployed in prod on the next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants