perry try fix release yaml #8715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
perryjrandall
commented
Jun 16, 2023
perryjrandall
commented
- [release] Turn of qs for release v1.5 ([release] Turn of qs for release v1.5 #8369)
- [aptos-vm] Do not log down storage error ([aptos-vm] Do not log down storage error #8383)
- [lto] Use thin LTO instead of default fat ([lto] Use thin LTO instead of default fat #8384)
- [Aptos Node] Bump cargo version of aptos-node to 1.5
- [Execution] Add TransactionDeduper trait and implementation using (hash, signature) ([Execution] Add TransactionDeduper trait and implementation using (hash, signature) #8367) ([Execution] Add TransactionDeduper trait and implementation using (hash, signature) (#8367) #8458)
- Turn on txn dedup and quorum store at genesis ([Devnet genesis] turn on txn dedup and quorum store at genesis #8459)
- cherry-pick: improved value depth checks in the VM (cherry-pick: improved value depth checks in the VM #8487)
- fix trigger condition for build jobs
- Update gas metering (Update gas metering #8526) ([cherry-pick] Update gas metering (#8526) #8533)
- cherry-pick: [gas] fix gas metering for resource groups ([gas] fix gas metering for resource groups #8549) (cherry-pick: [gas] fix gas metering for resource groups (#8549) #8580)
- Integrate fixes into mainnet (Integrate fixes into mainnet #8568) ([cherry-pick] fix for constructor #8582)
- Fix the order of signer and non-signer tx arg validation to maintain backward compatibility (Fix the order of signer and non-signer tx arg validation to maintain backward compatibility #8649) (Fix the order of signer and non-signer tx arg validation to maintain backward compatibility #8659)
- [CP][Fix] Return the correct version for state snapshot when the root is not committed. ([CP][Fix] Return the correct version for state snapshot when the root is not committed. #8672)
- [aptos-vm] Skip converting storage error ([cherry-pick][aptos-vm] Skip converting storage error #8675)
- [release] Fix framework release description to v1.5.0 ([release] Fix framework release description to v1.5.0 #8704)
- [release] Add source code url
Test Plan: testing with ci by adding label run-e2e-tests
Fat lto takes forever to compile, thin LTO acheives most of the benefit with little additional compile time Test Plan: perf build scheduled on PR via the build perf images label took 22 mins instead of 42 mins!
…sh, signature) (#8367) (#8458) Cherry-pick #8367. Expected to be a noop until onchain config is changed. ### Description Adding TransactionDeduper trait and an implementation. The dedup is done within a block, just before transaction shuffle. It's guarded by an onchain config. The purpose is to not send duplicate transactions to execution. While execution correctness is not affected by duplicates (and other work removed false error logs that fired due to them), it's possible that duplicate transactions could hurt throughput of parallel execution. By deduping ahead of time, we don't have to worry about that. The implementation finds duplicates by matching (raw txn bcs hash, signature). Because calculating hash can be relatively expensive, it is only done when a shallow match is found of (account, seq_no), and it's done in parallel. Overhead (as seen on forge): * When there are no duplicates, the dedup is negligible -- it takes ~2ms per second. * When there are ~100 duplicates per block, the dedup takes ~10ms per second. ### Test Plan Added unit tests.
This only turns on for genesis (for devnet only), without a corresponding governance proposal for now.
* Add accurate resource group gas metering * Add accurate resource group gas metering * fix * add test * Correct feature version * change trait signature * Clear any resource cache after proloque * bump gas feature * add comment * fix trigger condition for build jobs * test loadtest * add improvement * Fix respawn session whatever that maybe --------- Co-authored-by: Kevin <[email protected]> Co-authored-by: gerben <[email protected]> Co-authored-by: geekflyer <[email protected]>
Co-authored-by: gerben-stavenga <[email protected]>
… is not committed. (#8672)
Co-authored-by: Runtian Zhou <[email protected]>
* [release] Fix framework release description to v1.5.0 Test plan: is valid yaml :P * update with steps and right metadata --------- Co-authored-by: Frances Liu <[email protected]>
perryjrandall
requested review from
msmouse,
lightmark,
zekun000,
JoshLind,
davidiw,
movekevin,
wrwg,
vgao1996 and
a team
as code owners
Silly, add source code url TBD, i suspect this not being set is failing release job Test Plan: yq is valid yaml
perryjrandall
force-pushed
the
perry-try-fix-release-yaml
branch
from
19293a7 to
d013f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.