-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve txn-emitter stability and visibility on Forge #8697
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1580203
to
917d076
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
917d076
to
a9dea3f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a9dea3f
to
ff8636e
Compare
This comment has been minimized.
This comment has been minimized.
We have a few odd cases, and need to figure out if emitter is causing issues, or nodes.
ff8636e
to
1c59c35
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
// Creating workers is slow with many workers (TODO check why) | ||
// so we create them all first, before starting them - so they start at the right time for | ||
// traffic pattern to be correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it takes 5 minutes to go through the loop below, in the graceful overload case (https://aptoslabs.grafana.net/goto/GaWX1nu4g?orgId=1) with 180k workers to create, which makes no sense - but at least with this change it doesn't affect the measurements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix db flag that got changed recently for test tuned for throughput
what was this change?
#8697) We have a few odd cases, and need to figure out if emitter is causing issues, or nodes.
#8697) We have a few odd cases, and need to figure out if emitter is causing issues, or nodes.
aptos-labs#8697) We have a few odd cases, and need to figure out if emitter is causing issues, or nodes.
aptos-labs#8697) We have a few odd cases, and need to figure out if emitter is causing issues, or nodes.
#8697) We have a few odd cases, and need to figure out if emitter is causing issues, or nodes.
Description
Test Plan