-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aptos-vm] Skip converting storage error #8674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekun000
approved these changes
Jun 14, 2023
zekun000
reviewed
Jun 14, 2023
aptos-move/aptos-vm/src/errors.rs
Outdated
@@ -132,6 +132,10 @@ pub fn convert_prologue_error( | |||
}; | |||
VMStatus::Error(new_major_status, None) | |||
}, | |||
// Storage error can be a result of speculation failure so throw the error back for caller to handle. | |||
VMStatus::Error(StatusCode::STORAGE_ERROR, msg) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can write e @ VMStatus::Error(_) => e
sherry-x
approved these changes
Jun 15, 2023
rahxephon89
approved these changes
Jun 15, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
vusirikala
pushed a commit
that referenced
this pull request
Jun 21, 2023
* [aptos-vm] Skip converting storage error * fixup! [aptos-vm] Skip converting storage error
banool
pushed a commit
that referenced
this pull request
Jul 7, 2023
* [aptos-vm] Skip converting storage error * fixup! [aptos-vm] Skip converting storage error
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
* [aptos-vm] Skip converting storage error * fixup! [aptos-vm] Skip converting storage error
xbtmatt
pushed a commit
to xbtmatt/aptos-core
that referenced
this pull request
Jul 25, 2023
* [aptos-vm] Skip converting storage error * fixup! [aptos-vm] Skip converting storage error
gedigi
pushed a commit
that referenced
this pull request
Aug 2, 2023
* [aptos-vm] Skip converting storage error * fixup! [aptos-vm] Skip converting storage error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Storage error can be a result of speculation error and should thus not be treated as
UNEXPECTED_ERROR_FROM_KNOWN_MOVE_FUNCTION
.Test Plan
TBD