Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aptos-vm] Skip converting storage error #8674

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

runtian-zhou
Copy link
Contributor

Description

Storage error can be a result of speculation error and should thus not be treated as UNEXPECTED_ERROR_FROM_KNOWN_MOVE_FUNCTION.

Test Plan

TBD

@@ -132,6 +132,10 @@ pub fn convert_prologue_error(
};
VMStatus::Error(new_major_status, None)
},
// Storage error can be a result of speculation failure so throw the error back for caller to handle.
VMStatus::Error(StatusCode::STORAGE_ERROR, msg) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can write e @ VMStatus::Error(_) => e

@sherry-x sherry-x enabled auto-merge (squash) June 15, 2023 15:49
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> be5fe95af3eb9428acdaddbea9101e08e2972c3a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> be5fe95af3eb9428acdaddbea9101e08e2972c3a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : committed: 8886 txn/s, latency: 3756 ms, (p50: 3700 ms, p90: 5200 ms, p99: 6900 ms), latency samples: 311040
2. Upgrading first Validator to new version: be5fe95af3eb9428acdaddbea9101e08e2972c3a
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4822 txn/s, latency: 6673 ms, (p50: 7300 ms, p90: 8700 ms, p99: 9300 ms), latency samples: 173620
3. Upgrading rest of first batch to new version: be5fe95af3eb9428acdaddbea9101e08e2972c3a
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4466 txn/s, latency: 7067 ms, (p50: 7900 ms, p90: 8800 ms, p99: 9200 ms), latency samples: 165260
4. upgrading second batch to new version: be5fe95af3eb9428acdaddbea9101e08e2972c3a
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6553 txn/s, latency: 4942 ms, (p50: 5100 ms, p90: 7200 ms, p99: 8000 ms), latency samples: 229380
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> be5fe95af3eb9428acdaddbea9101e08e2972c3a passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on be5fe95af3eb9428acdaddbea9101e08e2972c3a

performance benchmark : committed: 5545 txn/s, latency: 7143 ms, (p50: 5900 ms, p90: 9900 ms, p99: 27200 ms), latency samples: 2367760
Max round gap was 1 [limit 4] at version 553013. Max no progress secs was 3.862169 [limit 10] at version 2457451.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> be5fe95af3eb9428acdaddbea9101e08e2972c3a

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> be5fe95af3eb9428acdaddbea9101e08e2972c3a (PR)
Upgrade the nodes to version: be5fe95af3eb9428acdaddbea9101e08e2972c3a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4965 txn/s, latency: 6379 ms, (p50: 6400 ms, p90: 9200 ms, p99: 12100 ms), latency samples: 188680
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> be5fe95af3eb9428acdaddbea9101e08e2972c3a passed
Test Ok

@sherry-x sherry-x merged commit 74ccc19 into main Jun 15, 2023
@sherry-x sherry-x deleted the runtianz/skip_storage_error_for_failure branch June 15, 2023 16:28
vusirikala pushed a commit that referenced this pull request Jun 21, 2023
* [aptos-vm] Skip converting storage error

* fixup! [aptos-vm] Skip converting storage error
banool pushed a commit that referenced this pull request Jul 7, 2023
* [aptos-vm] Skip converting storage error

* fixup! [aptos-vm] Skip converting storage error
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
* [aptos-vm] Skip converting storage error

* fixup! [aptos-vm] Skip converting storage error
xbtmatt pushed a commit to xbtmatt/aptos-core that referenced this pull request Jul 25, 2023
* [aptos-vm] Skip converting storage error

* fixup! [aptos-vm] Skip converting storage error
gedigi pushed a commit that referenced this pull request Aug 2, 2023
* [aptos-vm] Skip converting storage error

* fixup! [aptos-vm] Skip converting storage error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants