Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multisig address generation in multisig.py example #8668

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Fix multisig address generation in multisig.py example #8668

merged 1 commit into from
Jul 2, 2023

Conversation

kPatch
Copy link
Contributor

@kPatch kPatch commented Jun 14, 2023

Description

AccountAddress class is missing from_multisig_schema function.
Using from_multi_ed25519 instead.

multisig_address = AccountAddress.from_multisig_schema(
        [alice.public_key(), bob.public_key(), chad.public_key()], threshold
    )

Test Plan

Inside Python sdk directory, run the following command:

poetry run python -m examples.multisig

@kPatch
Fix multisig address generation in multisig.py example
d27fea2 
AccountAddress class is missing `from_multisig_schema` function, use `from_multi_ed25519` instead.

```
multisig_address = AccountAddress.from_multisig_schema(
        [alice.public_key(), bob.public_key(), chad.public_key()], threshold
    )
```
@davidiw davidiw merged commit 6283e8a into aptos-labs:main Jul 2, 2023
gedigi pushed a commit that referenced this pull request Aug 2, 2023
@kPatch @gedigi
Fix multisig address generation in multisig.py example (#8668)
4002c85 
AccountAddress class is missing `from_multisig_schema` function, use `from_multi_ed25519` instead.

```
multisig_address = AccountAddress.from_multisig_schema(
        [alice.public_key(), bob.public_key(), chad.public_key()], threshold
    )
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmaayan 0xmaayan 0xmaayan approved these changes

@gregnazario gregnazario gregnazario approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@banool banool Awaiting requested review from banool

@0xmigo 0xmigo Awaiting requested review from 0xmigo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kPatch @gregnazario @0xmaayan @davidiw