[RFC] Add native function create_uuid

aptos-move/aptos-gas/src/aptos_framework.rs

@@ -163,7 +163,10 @@ crate::natives::define_gas_parameters_for_natives!(GasParameters, "aptos_framewo
     [.util.from_bytes.base, "util.from_bytes.base", 300 * MUL],
     [.util.from_bytes.per_byte, "util.from_bytes.per_byte", 5 * MUL],
 
+    [.transaction_context.get_txn_hash.base, { 9.. => "transaction_context.get_txn_hash.base" }, 200 * MUL],
     [.transaction_context.get_script_hash.base, "transaction_context.get_script_hash.base", 200 * MUL],
+    // Using SHA2-256's cost
+    [.transaction_context.create_unique_address.base, { 9.. => "transaction_context.create_unique_address.base" }, 3000 * MUL],
 
     [.code.request_publish.base, "code.request_publish.base", 500 * MUL],
     [.code.request_publish.per_byte, "code.request_publish.per_byte", 2 * MUL],

aptos-move/aptos-gas/src/gas_meter.rs

@@ -36,6 +36,7 @@ use std::collections::BTreeMap;
 // - V10
 //   - Storage gas charges (excluding "storage fees") stop respecting the storage gas curves
 // - V9
+//   - Added create_uuid and get_txn_hash native functions
 //   - Accurate tracking of the cost of loading resource groups
 // - V8
 //   - Added BLS12-381 operations.

aptos-move/aptos-vm/src/move_vm_ext/vm.rs

@@ -113,7 +113,11 @@ impl MoveVmExt {
             _ => vec![],
         };
 
-        extensions.add(NativeTransactionContext::new(script_hash, self.chain_id));
+        extensions.add(NativeTransactionContext::new(
+            txn_hash.to_vec(),
+            script_hash,
+            self.chain_id,
+        ));
         extensions.add(NativeCodeContext::default());
         extensions.add(NativeStateStorageContext::new(remote));
 

aptos-move/aptos-vm/src/natives.rs

@@ -91,7 +91,11 @@ pub fn configure_for_unit_test() {
 #[cfg(feature = "testing")]
 fn unit_test_extensions_hook(exts: &mut NativeContextExtensions) {
     exts.add(NativeCodeContext::default());
-    exts.add(NativeTransactionContext::new(vec![1], ChainId::test().id())); // We use the testing environment chain ID here
+    exts.add(NativeTransactionContext::new(
+        vec![1],
+        vec![1],
+        ChainId::test().id(),
+    )); // We use the testing environment chain ID here
     exts.add(NativeAggregatorContext::new(
         [0; 32],
         &*DUMMY_RESOLVER,

aptos-move/e2e-move-tests/src/lib.rs

@@ -5,6 +5,7 @@ pub mod aggregator;
 pub mod aptos_governance;
 pub mod harness;
 pub mod stake;
+pub mod transaction_context;
 pub mod transaction_fee;
 
 use anyhow::bail;

aptos-move/e2e-move-tests/src/tests/mod.rs

@@ -35,6 +35,7 @@ mod state_metadata;
 mod string_args;
 mod token_event_store;
 mod token_objects;
+mod transaction_context;
 mod transaction_fee;
 mod type_too_large;
 mod vector_numeric_address;

aptos-move/e2e-move-tests/src/tests/transaction_context.data/Move.toml

@@ -0,0 +1,6 @@
+[package]
+name = "transaction_context_test"
+version = "0.0.0"
+
+[dependencies]
+AptosFramework = { local = "../../../../framework/aptos-framework" }

aptos-move/e2e-move-tests/src/tests/transaction_context.data/sources/transaction_context_test.move

@@ -0,0 +1,25 @@
+module 0x1::transaction_context_test {
+    use std::vector;
+    use aptos_framework::transaction_context::create_uuid;
+
+    /// When checking the value of aggregator fails.
+    const ENOT_UNIQUE: u64 = 20;
+
+    public entry fun create_many_uuids(_account: &signer, count: u64) {
+        let uuids: vector<address> = vector<address>[];
+        let i: u64 = 0;
+        while (i < count) {
+            i = i+1;
+            vector::push_back(&mut uuids, create_uuid());
+        };
+        i = 0;
+        while (i < count - 1) {
+            let j: u64 = i + 1;
+            while (j < count) {
+                assert!(*vector::borrow(&uuids, i) != *vector::borrow(&uuids, j), ENOT_UNIQUE);
+                j = j + 1;
+            };
+            i = i + 1;
+        };
+    }
+}

aptos-move/e2e-move-tests/src/tests/transaction_context.rs

@@ -0,0 +1,20 @@
+use crate::{
+    assert_success,
+    tests::common,
+    transaction_context::{create_many_uuids, initialize},
+    MoveHarness,
+};
+use aptos_language_e2e_tests::account::Account;
+
+fn setup() -> (MoveHarness, Account) {
+    initialize(common::test_dir_path("transaction_context.data"))
+}
+
+#[test]
+fn test_many_unique_uuids() {
+    let (mut h, acc) = setup();
+
+    let txn1 = create_many_uuids(&mut h, &acc, 50);
+
+    assert_success!(h.run(txn1));
+}

aptos-move/e2e-move-tests/src/transaction_context.rs

@@ -0,0 +1,27 @@
+// Copyright © Aptos Foundation
+// SPDX-License-Identifier: Apache-2.0
+
+use crate::{assert_success, harness::MoveHarness};
+use aptos_language_e2e_tests::account::Account;
+use aptos_types::{account_address::AccountAddress, transaction::SignedTransaction};
+use std::path::PathBuf;
+
+pub fn initialize(path: PathBuf) -> (MoveHarness, Account) {
+    let mut harness = MoveHarness::new();
+    let account = harness.new_account_at(AccountAddress::ONE);
+    assert_success!(harness.publish_package(&account, &path));
+    (harness, account)
+}
+
+pub fn create_many_uuids(
+    harness: &mut MoveHarness,
+    account: &Account,
+    count: u64,
+) -> SignedTransaction {
+    harness.create_entry_function(
+        account,
+        str::parse("0x1::transaction_context_test::create_many_uuids").unwrap(),
+        vec![],
+        vec![bcs::to_bytes(&count).unwrap()],
+    )
+}

aptos-move/framework/aptos-framework/doc/object.md

@@ -42,6 +42,7 @@ make it so that a reference to a global object can be returned from a function.
 -  [Function `convert`](#0x1_object_convert)
 -  [Function `create_named_object`](#0x1_object_create_named_object)
 -  [Function `create_user_derived_object`](#0x1_object_create_user_derived_object)
+-  [Function `create_object`](#0x1_object_create_object)
 -  [Function `create_object_from_account`](#0x1_object_create_object_from_account)
 -  [Function `create_object_from_object`](#0x1_object_create_object_from_object)
 -  [Function `create_object_from_guid`](#0x1_object_create_object_from_guid)
@@ -87,6 +88,7 @@ make it so that a reference to a global object can be returned from a function.
 <b>use</b> <a href="guid.md#0x1_guid">0x1::guid</a>;
 <b>use</b> <a href="../../aptos-stdlib/../move-stdlib/doc/hash.md#0x1_hash">0x1::hash</a>;
 <b>use</b> <a href="../../aptos-stdlib/../move-stdlib/doc/signer.md#0x1_signer">0x1::signer</a>;
+<b>use</b> <a href="transaction_context.md#0x1_transaction_context">0x1::transaction_context</a>;
 <b>use</b> <a href="../../aptos-stdlib/../move-stdlib/doc/vector.md#0x1_vector">0x1::vector</a>;
 </code></pre>
 
@@ -227,8 +229,7 @@ This is a one time ability given to the creator to configure the object as neces
 <code>can_delete: bool</code>
 </dt>
 <dd>
- Set to true so long as deleting the object is possible. For example, the object was
- created via create_object_from_guid.
+ Set to true so long as deleting the object is possible.
 </dd>
 </dl>
 
@@ -828,12 +829,42 @@ Derivde objects, similar to named objects, cannot be deleted.
 
 
 
+</details>
+
+<a name="0x1_object_create_object"></a>
+
+## Function `create_object`
+
+Create a new object by generating a random UUID based on transaction hash.
+The UUID is computed sha3_256([transaction hash | uuid counter | 0xFB]).
+The created object is deletable as we can guarantee the same UUID can
+never be regenerated with future txs.
+
+
+<pre><code><b>public</b> <b>fun</b> <a href="object.md#0x1_object_create_object">create_object</a>(creator_address: <b>address</b>): <a href="object.md#0x1_object_ConstructorRef">object::ConstructorRef</a>
+</code></pre>
+
+
+
+<details>
+<summary>Implementation</summary>
+
+
+<pre><code><b>public</b> <b>fun</b> <a href="object.md#0x1_object_create_object">create_object</a>(creator_address: <b>address</b>): <a href="object.md#0x1_object_ConstructorRef">ConstructorRef</a> {
+    <b>let</b> uuid = aptos_framework::transaction_context::create_unique_addr();
+    <a href="object.md#0x1_object_create_object_internal">create_object_internal</a>(creator_address, uuid, <b>true</b>)
+}
+</code></pre>
+
+
+
 </details>
 
 <a name="0x1_object_create_object_from_account"></a>
 
 ## Function `create_object_from_account`
 
+Deprecated. Use <code>create_object</code> instead.
 Create a new object from a GUID generated by an account.
 
 
@@ -860,6 +891,7 @@ Create a new object from a GUID generated by an account.
 
 ## Function `create_object_from_object`
 
+Deprecated. Use <code>create_object</code> instead.
 Create a new object from a GUID generated by an object.