Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus-only] fix gas_limit execution #8248

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

ibalajiarun
Copy link
Contributor

Description

This PR fixes consensus-only test breakage by implementing execute_block_with_gas_limit for the feature. It simply falls back to executing without gas limits.

Test Plan

consensus-only smoke test.

@ibalajiarun ibalajiarun enabled auto-merge (squash) May 17, 2023 18:40
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10000 TPS, 3759 ms latency, 6300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a
compatibility::simple-validator-upgrade::single-validator-upgrade : 6132 TPS, 6385 ms latency, 8400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a
compatibility::simple-validator-upgrade::half-validator-upgrade : 5396 TPS, 7453 ms latency, 9900 ms p99 latency,no expired txns
4. upgrading second batch to new version: dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7227 TPS, 5216 ms latency, 8300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a

performance benchmark : 6174 TPS, 6407 ms latency, 17900 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a (PR)
Upgrade the nodes to version: dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a
framework_upgrade::framework-upgrade::full-framework-upgrade : 5965 TPS, 6890 ms latency, 21000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> dc3f23c67c040a40901a99f3c5c8d9707c4a6f5a passed
Test Ok

@ibalajiarun ibalajiarun merged commit 3277100 into main May 17, 2023
@ibalajiarun ibalajiarun deleted the balaji/fix-consensus-only branch May 17, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants