[TS SDK] Add TokenV2 Indexer queries #8210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
requested review from
davidiw,
junkil-park,
bowenyang007,
movekevin and
0xmigo
0xmaayan
commented
May 16, 2023
movekevin
reviewed
May 16, 2023
movekevin
reviewed
May 16, 2023
| * Queries all tokens of a specific collection that an account owns | ||
| * | ||
| * @param ownerAddress owner address | ||
| * @param collectionAddress the collection address |
There was a problem hiding this comment.
We should clarify what collection address means. May be with a link to the token v2 doc page as well (or a TODO if that's not complete yet) cc @gregnazario
| * can pass an optional `tokenStandard` parameter to query a specific standard | ||
| * | ||
| * @param creatorAddress the collection creator address | ||
| * @param collectionName the collection name |
There was a problem hiding this comment.
May be provide an example?
0xmaayan
commented
May 16, 2023
0xmigo
reviewed
May 17, 2023
| creatorAddress: MaybeHexString, | ||
| collectionName: string, | ||
| extraArgs?: { | ||
| tokenStandard?: TokenStandard; |
There was a problem hiding this comment.
hm, does this mean that there could be 2 different standard from the same collection? For example, AptosMonkey v1, and AptosMonkey v2 collection?
There was a problem hiding this comment.
it is not the same collection, these are 2 different collection that were created with the same account and have the same name.
for example
bowenyang007
approved these changes
May 17, 2023
0xmigo
approved these changes
May 17, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
gedigi
pushed a commit
that referenced
this pull request
Jun 6, 2023
* add get account token query * add get account collection tokens * update changelog * add function comment * add function comment * fix lint * address feedback * update changelog * fix lint * typo * token ownership fields fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Indexer queries
getAccountTokens- get all tokens that an account ownsgetAccountCollectionTokensByCollectionAddress- get all tokens of a specific collection that an account ownsgetCollectionData- get the collection data (if, for some reason, a creator account has 2 collections with the same name in v1 and v2, can use an optional tokenStandard parameter to query a specific standard)getCollectionAddress- get the collection address (if, for some reason, a creator account has 2 collections with the same name in v1 and v2, can use an optional tokenStandard parameter to query a specific standard)with this,
In a next PR we will add support for (not yet supported on the indexer side)
Test Plan
tests are passing