Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timed_features] Clean up already enabled flags #8159

Merged
merged 1 commit into from
May 17, 2023

Conversation

runtian-zhou
Copy link
Contributor

Description

Clean up the code for already published timed features. I'll create a separate PR to clean up parts involved in the Move repo.

Test Plan

We need to trigger a replay testing to make sure we didn't revert any changes

@runtian-zhou runtian-zhou force-pushed the runtianz/clean_up_timed_features branch from eff55a6 to c329493 Compare May 11, 2023 22:22
Copy link
Contributor

@movekevin movekevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldnt this break replay?

@runtian-zhou
Copy link
Contributor Author

They wont! Because those features are already activated on mainnet and we replay overrided the flag already so we shouldn't see any behavior change.

Copy link
Contributor

@zekun000 zekun000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

Copy link
Contributor

@alinush alinush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cryptography stuff looks good to me!

Copy link
Contributor

@alinush alinush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cryptography stuff looks good to me!

@runtian-zhou runtian-zhou force-pushed the runtianz/clean_up_timed_features branch from ba3446f to 9baf67b Compare May 12, 2023 21:07
@runtian-zhou
Copy link
Contributor Author

Triggered replay manually and succeeded: https://github.com/aptos-labs/aptos-core/actions/runs/4995643628

@runtian-zhou runtian-zhou enabled auto-merge (squash) May 17, 2023 06:19
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9baf67bd0b04061435a3301c3dd561204813ac0a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9baf67bd0b04061435a3301c3dd561204813ac0a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 10164 TPS, 3691 ms latency, 6400 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 9baf67bd0b04061435a3301c3dd561204813ac0a
compatibility::simple-validator-upgrade::single-validator-upgrade : 5513 TPS, 7284 ms latency, 10000 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 9baf67bd0b04061435a3301c3dd561204813ac0a
compatibility::simple-validator-upgrade::half-validator-upgrade : 5572 TPS, 7127 ms latency, 9400 ms p99 latency,no expired txns
4. upgrading second batch to new version: 9baf67bd0b04061435a3301c3dd561204813ac0a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 8032 TPS, 4738 ms latency, 8100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9baf67bd0b04061435a3301c3dd561204813ac0a passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 9baf67bd0b04061435a3301c3dd561204813ac0a

performance benchmark : 5788 TPS, 6784 ms latency, 27400 ms p99 latency,(!) expired 446 out of 2471960 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 9baf67bd0b04061435a3301c3dd561204813ac0a

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 9baf67bd0b04061435a3301c3dd561204813ac0a (PR)
Upgrade the nodes to version: 9baf67bd0b04061435a3301c3dd561204813ac0a
framework_upgrade::framework-upgrade::full-framework-upgrade : 1642 TPS, 31286 ms latency, 41400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 9baf67bd0b04061435a3301c3dd561204813ac0a passed
Test Ok

@runtian-zhou runtian-zhou merged commit d0f1d85 into main May 17, 2023
@runtian-zhou runtian-zhou deleted the runtianz/clean_up_timed_features branch May 17, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants