-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[timed_features] Clean up already enabled flags #8159
Conversation
eff55a6
to
c329493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldnt this break replay?
They wont! Because those features are already activated on mainnet and we replay overrided the flag already so we shouldn't see any behavior change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cryptography stuff looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cryptography stuff looks good to me!
ba3446f
to
9baf67b
Compare
Triggered replay manually and succeeded: https://github.com/aptos-labs/aptos-core/actions/runs/4995643628 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Description
Clean up the code for already published timed features. I'll create a separate PR to clean up parts involved in the Move repo.
Test Plan
We need to trigger a replay testing to make sure we didn't revert any changes