Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flag to skip fetching git deps in aptos move test #7931

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented Apr 26, 2023

Description

This is a fun little PTO PR. While working on a side project on a plane I noticed that aptos move test doesn't work when you don't have internet because we don't actually respect the --skip-fetch-latest-git-deps flag. This PR fixes that.

Test Plan

While offline.

Before:

$ aptos move test --skip-fetch-latest-git-deps --named-addresses addr=0x1
Compiling, may take a little while to download git dependencies...
INCLUDING DEPENDENCY AptosFramework
INCLUDING DEPENDENCY AptosStdlib
INCLUDING DEPENDENCY MoveStdlib
BUILDING tontine
{
  "Error": "Unexpected error: Unable to resolve packages for package 'tontine'"
}

After:

$ cargo run -p aptos -- move test --skip-fetch-latest-git-deps --named-addresses addr=0x1 --package-dir ~/github/aptos-tontine/move
INCLUDING DEPENDENCY AptosFramework
INCLUDING DEPENDENCY AptosStdlib
INCLUDING DEPENDENCY MoveStdlib
BUILDING tontine
Running Move unit tests
...

@banool banool requested a review from gregnazario as a code owner April 26, 2023 03:26
@banool banool requested a review from 0xmigo April 26, 2023 03:27
@gregnazario gregnazario enabled auto-merge (squash) April 26, 2023 03:41
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@banool banool force-pushed the banool/fix-skip-git-deps-move-test branch from 2544702 to c06ca74 Compare April 26, 2023 04:22
@banool banool requested a review from saharct as a code owner April 26, 2023 04:22
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c06ca74614b96167c68c01fafe6152af080e1d1d

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c06ca74614b96167c68c01fafe6152af080e1d1d (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7672 TPS, 4997 ms latency, 7400 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: c06ca74614b96167c68c01fafe6152af080e1d1d
compatibility::simple-validator-upgrade::single-validator-upgrade : 4284 TPS, 9572 ms latency, 12900 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: c06ca74614b96167c68c01fafe6152af080e1d1d
compatibility::simple-validator-upgrade::half-validator-upgrade : 4120 TPS, 9499 ms latency, 12900 ms p99 latency,no expired txns
4. upgrading second batch to new version: c06ca74614b96167c68c01fafe6152af080e1d1d
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6112 TPS, 6395 ms latency, 10200 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c06ca74614b96167c68c01fafe6152af080e1d1d passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on c06ca74614b96167c68c01fafe6152af080e1d1d

performance benchmark : 5195 TPS, 7613 ms latency, 26700 ms p99 latency,(!) expired 287 out of 2218820 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c06ca74614b96167c68c01fafe6152af080e1d1d

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c06ca74614b96167c68c01fafe6152af080e1d1d (PR)
Upgrade the nodes to version: c06ca74614b96167c68c01fafe6152af080e1d1d
framework_upgrade::framework-upgrade::full-framework-upgrade : 5435 TPS, 7398 ms latency, 10500 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> c06ca74614b96167c68c01fafe6152af080e1d1d passed
Test Ok

@gregnazario gregnazario merged commit e735a68 into main Apr 26, 2023
@gregnazario gregnazario deleted the banool/fix-skip-git-deps-move-test branch April 26, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants