Remove unsafe

[gerben-stavenga]

Description

Over the weekend I investigated some SIGSEGV I experienced and was looking at unsafe code in our code base as possible culprits. I encountered this which I initially thought must be wrong (Option<Box> is type punned as an usize). It turns out that absolute compiler magic makes Option<Box> the same size as usize, but I feel that kind of code is ridiculous.

The problem is that one cannot use [None, NB_BUCKETS] as Bucket == Option<Box> is non-copyable, however one can simply work around that by using cont INIT: Bucket = None, and use INIT as initialization value.

This seems cleaner

[davidiw]

Very clean indeed, I don't suppose you have a test that would demonstrate how to get the sigsegv?

[gerben-stavenga]

The sigsegv was caused by stack overflow, (I had raised the stack limit with ulimit -s but that didnt help but wolfgang pointed me to env RUST_MIN_STACK) while investigating the memory I stumbled upon this

[github-actions]

✅ Forge suite land_blocking success on 61dcf49f14ce4c9312d0ff138a415db4fb333763

performance benchmark with full nodes : 5608 TPS, 7049 ms latency, 12000 ms p99 latency,(!) expired 520 out of 2395380 txns
Test Ok

• Grafana dashboard
• Humio Logs
• Pyroscope Profiling
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 61dcf49f14ce4c9312d0ff138a415db4fb333763

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 61dcf49f14ce4c9312d0ff138a415db4fb333763 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7770 TPS, 4904 ms latency, 7400 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 61dcf49f14ce4c9312d0ff138a415db4fb333763
compatibility::simple-validator-upgrade::single-validator-upgrade : 4810 TPS, 8355 ms latency, 11400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 61dcf49f14ce4c9312d0ff138a415db4fb333763
compatibility::simple-validator-upgrade::half-validator-upgrade : 4492 TPS, 9043 ms latency, 12200 ms p99 latency,no expired txns
4. upgrading second batch to new version: 61dcf49f14ce4c9312d0ff138a415db4fb333763
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6496 TPS, 5937 ms latency, 11400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 61dcf49f14ce4c9312d0ff138a415db4fb333763 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Pyroscope Profiling
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 61dcf49f14ce4c9312d0ff138a415db4fb333763

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 61dcf49f14ce4c9312d0ff138a415db4fb333763 (PR)
Upgrade the nodes to version: 61dcf49f14ce4c9312d0ff138a415db4fb333763
framework_upgrade::framework-upgrade::full-framework-upgrade : 6447 TPS, 6219 ms latency, 8600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 61dcf49f14ce4c9312d0ff138a415db4fb333763 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Pyroscope Profiling
• Test runner output
• Test run is land-blocking