reuse move-stdlib sha2 gas parameters in aptos-stdlib #7568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjma
requested review from
alinush,
davidiw,
movekevin,
wrwg,
zekun000 and
vgao1996
as code owners
alinush
reviewed
Apr 4, 2023
| move_stdlib::natives::all_natives(CORE_CODE_ADDRESS, gas_params.move_stdlib) | ||
| .into_iter() | ||
| .filter(|(_, name, _, _)| name.as_str() != "vector") | ||
| .chain(aptos_framework::natives::all_natives( | ||
| CORE_CODE_ADDRESS, | ||
| sha256_gas_params, |
There was a problem hiding this comment.
You could've passed all the Move gas parameters here because it's likely that, down the road, we will need those other parameters too.
zjma
added a commit
that referenced
this pull request
Apr 7, 2023
* generic algebraic structures and operations in move, plus bls12381 implementation * fix prover test failures * update * update doc * update msm gas cost * hash_to gas formula update * type names and documentations * update groth16 example * update gas formula for dst shortening * format name update * update gas parameters * update gas scripts to not depend on MUL * reuse move-stdlib sha2 gas parameters in aptos-stdlib (#7568) * reuse move-stdlib sha2 gas parameters in aptos-stdlib * cleanup * update doc * shorten symbol names * doc update * update gas script readme * rename module to crypt_algebra (#7586) * better module names * aptos framework now has access to the full move stdlib gas params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHA2-256 will be used in the new algebra module in aptos-stdlib, and it would be great to reuse the gas parameters defined in move-stdlib.