Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the Aptos Names Service doc header #7461

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

saharct
Copy link
Contributor

@saharct saharct commented Mar 29, 2023

I shortened the header since it takes up two lines instead of one like in the other docs.

image

@saharct saharct requested a review from angieyth March 29, 2023 00:37
@saharct saharct requested a review from clay-aptos as a code owner March 29, 2023 00:37
Copy link
Contributor

@clay-aptos clay-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clay-aptos
Copy link
Contributor

Thanks! I am removing the same "UI package" verbiage from the related announcement here:
#7457

@saharct saharct enabled auto-merge (squash) March 29, 2023 23:22
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 2c23198abe954675259db776f4f5a5d94926d574

performance benchmark with full nodes : 5831 TPS, 6800 ms latency, 10800 ms p99 latency,(!) expired 120 out of 2490040 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2c23198abe954675259db776f4f5a5d94926d574

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2c23198abe954675259db776f4f5a5d94926d574 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 8134 TPS, 4685 ms latency, 6800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 2c23198abe954675259db776f4f5a5d94926d574
compatibility::simple-validator-upgrade::single-validator-upgrade : 4631 TPS, 8386 ms latency, 11900 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 2c23198abe954675259db776f4f5a5d94926d574
compatibility::simple-validator-upgrade::half-validator-upgrade : 5022 TPS, 7690 ms latency, 10700 ms p99 latency,no expired txns
4. upgrading second batch to new version: 2c23198abe954675259db776f4f5a5d94926d574
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6848 TPS, 5592 ms latency, 10300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2c23198abe954675259db776f4f5a5d94926d574 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 2c23198abe954675259db776f4f5a5d94926d574

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 2c23198abe954675259db776f4f5a5d94926d574 (PR)
Upgrade the nodes to version: 2c23198abe954675259db776f4f5a5d94926d574
framework_upgrade::framework-upgrade::full-framework-upgrade : 6328 TPS, 6166 ms latency, 8800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 2c23198abe954675259db776f4f5a5d94926d574 passed
Test Ok

@saharct saharct merged commit d952a8e into main Mar 30, 2023
@saharct saharct deleted the saharct/aptos-names-service branch March 30, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants