Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] consensus improvement for v1.2 #7349

Merged
merged 1 commit into from
Mar 23, 2023
Merged

[cherry-pick] consensus improvement for v1.2 #7349

merged 1 commit into from
Mar 23, 2023

Conversation

zekun000
Copy link
Contributor

@zekun000 zekun000 commented Mar 23, 2023 •
edited
Loading

  • dispatch message verification into multiple thread executor
  • increase the message channel size and fix the ordering
  • increase the state sync threshold to compensate large pipeline

@zekun000 zekun000 added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Mar 23, 2023
igor-aptos
igor-aptos approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@igor-aptos igor-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 97945e1bfd65172ea3103f66360d103d31e6f319

performance benchmark with full nodes : 6070 TPS, 6547 ms latency, 11100 ms p99 latency,(!) expired 120 out of 2592200 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 97945e1bfd65172ea3103f66360d103d31e6f319

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 97945e1bfd65172ea3103f66360d103d31e6f319 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7394 TPS, 5240 ms latency, 7700 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 97945e1bfd65172ea3103f66360d103d31e6f319
compatibility::simple-validator-upgrade::single-validator-upgrade : 4120 TPS, 9758 ms latency, 13100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 97945e1bfd65172ea3103f66360d103d31e6f319
compatibility::simple-validator-upgrade::half-validator-upgrade : 4428 TPS, 9066 ms latency, 11900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 97945e1bfd65172ea3103f66360d103d31e6f319
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6308 TPS, 6210 ms latency, 10900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 97945e1bfd65172ea3103f66360d103d31e6f319 passed
Test Ok

@sherry-x sherry-x marked this pull request as ready for review March 23, 2023 23:28
@sherry-x sherry-x merged commit 942dc6d into aptos-node-v1.2.0 Mar 23, 2023
@sherry-x sherry-x deleted the zekun/cherrypick2 branch March 23, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-aptos igor-aptos igor-aptos approved these changes

@sherry-x sherry-x sherry-x approved these changes

@davidiw davidiw davidiw approved these changes

Assignees
No one assigned
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zekun000 @davidiw @sherry-x @igor-aptos