Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] adding ANS UI library documentation #7212

Merged
merged 10 commits into from
Mar 24, 2023

Conversation

angieyth
Copy link
Contributor

@angieyth angieyth commented Mar 16, 2023

Description

Adding the documentation for ANS UI package.

Test Plan

follow the instruction, and go to http://localhost:3000 to check the result.

Screen Shot 2023-03-16 at 1 44 06 PM
Screen Shot 2023-03-16 at 1 44 15 PM
Screen Shot 2023-03-16 at 1 44 26 PM

@angieyth angieyth changed the title adding ANS UI library documentation [documentation] adding ANS UI library documentation Mar 16, 2023
@angieyth angieyth force-pushed the angie/ans_documentation branch from 79ffcaa to 4bd4faf Compare March 16, 2023 20:42
@angieyth angieyth force-pushed the angie/ans_documentation branch from 4bd4faf to 9364bd2 Compare March 16, 2023 23:43
@clay-aptos
Copy link
Contributor

clay-aptos commented Mar 17, 2023

Fantastic work, @angieyth !

Hi @saharct , please help Angie with editing and when ready getting the file in navigation. The latter can happen in a distinct PR. Thank you both!

@angieyth angieyth force-pushed the angie/ans_documentation branch from 9364bd2 to 559d237 Compare March 17, 2023 23:37
Copy link
Contributor

@saharct saharct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process works for me after changing some things. Thanks, @angieyth!

@saharct
Copy link
Contributor

saharct commented Mar 23, 2023

I tested it with yarn and npm. I added a prerequisites section, yarn commands, and some more details to the instructions portion. Thanks!

@angieyth
Copy link
Contributor Author

thank you @saharct for helping out. should I merge now?

@saharct saharct requested review from 0xmaayan and banool March 23, 2023 17:38
@saharct
Copy link
Contributor

saharct commented Mar 23, 2023

You're welcome, @angieyth! We still need 1 more reviewer to approve the PR. Perhaps @0xmaayan or @banool can take a look at it.

Copy link
Contributor

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on ceff2539b8023db8d2a7e77638d313fd9834879a

performance benchmark with full nodes : 5896 TPS, 6720 ms latency, 8700 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ceff2539b8023db8d2a7e77638d313fd9834879a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ceff2539b8023db8d2a7e77638d313fd9834879a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 8051 TPS, 4771 ms latency, 7200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: ceff2539b8023db8d2a7e77638d313fd9834879a
compatibility::simple-validator-upgrade::single-validator-upgrade : 4494 TPS, 8799 ms latency, 11300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: ceff2539b8023db8d2a7e77638d313fd9834879a
compatibility::simple-validator-upgrade::half-validator-upgrade : 4828 TPS, 7935 ms latency, 10600 ms p99 latency,no expired txns
4. upgrading second batch to new version: ceff2539b8023db8d2a7e77638d313fd9834879a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6769 TPS, 6002 ms latency, 10100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> ceff2539b8023db8d2a7e77638d313fd9834879a passed
Test Ok

@github-actions
Copy link
Contributor

❌ Forge suite framework_upgrade failure on cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> ceff2539b8023db8d2a7e77638d313fd9834879a

Compatibility test results for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> ceff2539b8023db8d2a7e77638d313fd9834879a (PR)
Upgrade the nodes to version: ceff2539b8023db8d2a7e77638d313fd9834879a
Test Failed: API error: Unknown error Transaction committed on chain, but failed execution: Transaction Executed and Committed with Error CONSTRAINT_NOT_SATISFIED
Trailing Log Lines:
INCLUDING DEPENDENCY MoveStdlib
BUILDING ExecuteProposal
::error::API error: Unknown error Transaction committed on chain, but failed execution: Transaction Executed and Committed with Error CONSTRAINT_NOT_SATISFIED
test framework_upgrade::framework-upgrade ... FAILED
Error: API error: Unknown error Transaction committed on chain, but failed execution: Transaction Executed and Committed with Error CONSTRAINT_NOT_SATISFIED
Test Statistics: 
Compatibility test results for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> ceff2539b8023db8d2a7e77638d313fd9834879a (PR)
Upgrade the nodes to version: ceff2539b8023db8d2a7e77638d313fd9834879a
Test Failed: API error: Unknown error Transaction committed on chain, but failed execution: Transaction Executed and Committed with Error CONSTRAINT_NOT_SATISFIED


Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:281"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-7212-1679693424-cb4ba0a57c998c60cbab","timestamp":"2023-03-24T21:50:05.516498Z","message":"Deleting namespace forge-framework-upgrade-pr-7212: Some(NamespaceStatus { phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:389"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-7212-1679693424-cb4ba0a57c998c60cbab","timestamp":"2023-03-24T21:50:05.516521Z","message":"aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-7212"}

failures:
    framework_upgrade::framework-upgrade

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Failed to run tests:
Tests Failed
Error: Tests Failed
Debugging output:
NAME                                   READY   STATUS      RESTARTS   AGE
genesis-aptos-genesis-eforge81-s7nmp   0/1     Completed   0          18m

@angieyth angieyth merged commit 7f668d7 into main Mar 24, 2023
@angieyth angieyth deleted the angie/ans_documentation branch March 24, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Document Aptos Name Service in Aptos.dev
4 participants