Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add issue-links for stack-overflow/discord #6973

Merged
merged 2 commits into from Mar 8, 2023
Merged

add issue-links for stack-overflow/discord #6973

merged 2 commits into from Mar 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2023

closes #6928

Description

  • Drop question template
  • Add links to Stack Exchange Overflow and Discord

Test Plan

  • on a fork repo, merge the change to the default branch, the select "New Issue"

@ghost ghost requested review from clay-aptos and a team as code owners March 7, 2023 10:06
@clay-aptos clay-aptos requested a review from banool March 7, 2023 18:03
@@ -1 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: Questions and Help (on Stack Exchange)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on Stack Overflow

This comment was marked as spam.

@clay-aptos clay-aptos requested a review from gregnazario March 7, 2023 18:03
@clay-aptos
Copy link
Contributor

Thanks for the change. I am adding more reviewers and have left one comment.

@ghost ghost changed the title add issue-links for stackexchange/discord add issue-links for stack-overflow/discord Mar 7, 2023
@davidiw davidiw requested a review from saharct as a code owner March 8, 2023 03:07
@davidiw
Copy link
Contributor

davidiw commented Mar 8, 2023

Guess we'll see what this looks like....

@davidiw davidiw enabled auto-merge (squash) March 8, 2023 03:08
@davidiw davidiw disabled auto-merge March 8, 2023 03:08
@davidiw davidiw merged commit 6e6a251 into aptos-labs:main Mar 8, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b838005f830c9f7a67a49b05623b5ac715cc7f94

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b838005f830c9f7a67a49b05623b5ac715cc7f94 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 8136 TPS, 4655 ms latency, 7200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: b838005f830c9f7a67a49b05623b5ac715cc7f94
compatibility::simple-validator-upgrade::single-validator-upgrade : 5070 TPS, 7661 ms latency, 9800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: b838005f830c9f7a67a49b05623b5ac715cc7f94
compatibility::simple-validator-upgrade::half-validator-upgrade : 4964 TPS, 8104 ms latency, 10700 ms p99 latency,no expired txns
4. upgrading second batch to new version: b838005f830c9f7a67a49b05623b5ac715cc7f94
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6973 TPS, 5498 ms latency, 9100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b838005f830c9f7a67a49b05623b5ac715cc7f94 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

✅ Forge suite land_blocking success on b838005f830c9f7a67a49b05623b5ac715cc7f94

performance benchmark with full nodes : 5886 TPS, 6732 ms latency, 12300 ms p99 latency,(!) expired 500 out of 2514060 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

✅ Forge suite framework_upgrade success on cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> b838005f830c9f7a67a49b05623b5ac715cc7f94

Compatibility test results for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> b838005f830c9f7a67a49b05623b5ac715cc7f94 (PR)
Upgrade the nodes to version: b838005f830c9f7a67a49b05623b5ac715cc7f94
framework_upgrade::framework-upgrade::full-framework-upgrade : 6785 TPS, 5692 ms latency, 8600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> b838005f830c9f7a67a49b05623b5ac715cc7f94 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide stackexchange or github discussions q&a
2 participants