Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add origin/upstream remotes, minor edits #6932

Merged
merged 1 commit into from Mar 8, 2023
Merged

add origin/upstream remotes, minor edits #6932

merged 1 commit into from Mar 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2023

trivial

(Did the most important changes, the document needs still some revisions)

@ghost ghost requested a review from clay-aptos as a code owner March 5, 2023 19:29
Copy link
Contributor

@clay-aptos clay-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these improvements, @abebeos. I am adding our eng leads to confirm we want to encourage forking the repo. As you fixed, we already recommend it later in the README.

@ghost

This comment was marked as spam.

@clay-aptos
Copy link
Contributor

confirm we want to encourage forking the repo.

Note that this is standard-procedure for github.

And you even refer to upstream later in the doc

[davidiw](https://github.com/aptos-labs/aptos-core/blob/main/CONTRIBUTING.md#responding-to-reviewer-feedback)

git fetch upstream
git checkout topic
git rebase -i upstream/main

Agreed. Approving. Thanks again for your help!

@clay-aptos clay-aptos self-requested a review March 6, 2023 18:34
@clay-aptos
Copy link
Contributor

Noting I still want @davidiw or @gregnazario to confirm still.

@clay-aptos
Copy link
Contributor

Also, @abebeos , we are working on a section to better explain how to work together here:
#6417

I would appreciate your feedback on that. Can name drop you there too. :-)

@ghost

This comment was marked as spam.

@clay-aptos
Copy link
Contributor

Far to big, this overloads me immediately. I'll still give it a try tomorrow.

No worries. It's live now:
https://aptos.dev/community/help-index

@ghost

This comment was marked as spam.

Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh... it isn't too this flow has always been the bane of my existence...

@davidiw davidiw merged commit af4e858 into aptos-labs:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants