-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][TS SDK] integrate ANS functions #6000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's coming along well.
I don't think you need to include all the bytecode modules do you? Probably can be built and used at test time
If we're adding compiled bytecode we should also add CI that ensures the bytecode doesn't fall out of sync when the source code changes. If you can collect the commands you used to generate the bytecode in the first place I can help with that. |
The way I did it is
@gregnazario if I dont include the files, where should I read it from? |
I am not sure it would have any affect if the source code is changed. We compile the source code locally, and publish those files during tests, so the test knows about the local compiled files and not the changed source code |
I'm saying that in CI, we should compile the source code and make sure the bytecode matches the bytecode checked in. This is how we do it in aptos framework for example. |
Okay we spoke offline with Kevin and Jijun, probably better to go with a remote ABI downloading approach rather than a hardcode + CI approach. |
Yes, still need a way to compile and publish this package (or inject it when building the local testnet), this package is not part of the aptos core framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be both read and write?
If we can, let's resurrect this as just the read for lookups, it should be relatively simple (don't need all the entry functions). Then, we can come back on another pass to make writes & creating of names |
#7227 |
Description
getAddressByName
- get account address by ANS namegetNamebyAddress
- get ANS name by account address (waiting for [WIP] Adds reverse lookup support (primary name) aptos-names-contracts#4 )plugin
folder and keep all tests under__tests__
folder.Test Plan
tests are passing