Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add references to ANS in Accounts concept and See what's new #5877

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Add references to ANS in Accounts concept and See what's new #5877

merged 3 commits into from
Dec 14, 2022

Conversation

clay-aptos
Copy link
Contributor

Description

Test Plan

@clay-aptos clay-aptos requested a review from davidiw as a code owner December 14, 2022 18:36
@clay-aptos clay-aptos requested review from banool and 0xChucky and removed request for 0xChucky December 14, 2022 18:36
JoshLind
JoshLind reviewed Dec 14, 2022
View reviewed changes
developer-docs-site/docs/whats-new-in-docs.md
@@ -21,7 +25,7 @@ This page shows the key updates to the developer documentation on this site.

Framework upgrade through governance voting:
- Testnet upgrade - Nov 30th
- Mainnet upgrade - Dec 12th - 19th (7 days voting period)
- Mainnet upgrade - Dec 12th - 19th (7 days voting period) required by fullnode operators
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: only validator operators can vote. Fullnode operators can't. Does that make sense?

@clay-aptos clay-aptos enabled auto-merge (squash) December 14, 2022 22:03
@clay-aptos clay-aptos merged commit 55c85fc into main Dec 14, 2022
@clay-aptos clay-aptos deleted the ans branch December 14, 2022 22:04
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on b7abd20c46655f81fa8a9fc7aef79d160de6c2ac

performance benchmark with full nodes : 6243 TPS, 6363 ms latency, 10200 ms p99 latency,(!) expired 220 out of 2666020 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b7abd20c46655f81fa8a9fc7aef79d160de6c2ac

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b7abd20c46655f81fa8a9fc7aef79d160de6c2ac (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7530 TPS, 5152 ms latency, 7100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: b7abd20c46655f81fa8a9fc7aef79d160de6c2ac
compatibility::simple-validator-upgrade::single-validator-upgrade : 4638 TPS, 8610 ms latency, 12700 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: b7abd20c46655f81fa8a9fc7aef79d160de6c2ac
compatibility::simple-validator-upgrade::half-validator-upgrade : 4660 TPS, 8798 ms latency, 11300 ms p99 latency,no expired txns
4. upgrading second batch to new version: b7abd20c46655f81fa8a9fc7aef79d160de6c2ac
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6373 TPS, 6116 ms latency, 9600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b7abd20c46655f81fa8a9fc7aef79d160de6c2ac passed
Test Ok

areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@clay-aptos @areshand
Add references to ANS in Accounts concept and See what's new (aptos-l…
e7841b9 
…abs#5877)

* Add references to ANS in Accounts concept and See what's new

* Mainnet upgrade - Dec 12th - 19th (7 days voting period) required by fullnode operators

Co-authored-by: Clay Murphy <[email protected]>
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
@clay-aptos clay-aptos mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JoshLind JoshLind JoshLind approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@banool banool Awaiting requested review from banool

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clay-aptos @JoshLind