Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forge] Reduce the TPS requirement from 6000 to 5500 #5865

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

sitalkedia
Copy link
Contributor

Description

There has been some flakiness found in forge performance - reducing it temporarily to reduce the noise. We will increase it as we land single-node performance improvement items in next few months.

Test Plan

@sitalkedia sitalkedia enabled auto-merge (squash) December 12, 2022 22:10
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@gelash gelash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen much lower than 6000, should we set it to smt between 5500 and 6000?

@sitalkedia
Copy link
Contributor Author

I haven't seen much lower than 6000, should we set it to smt between 5500 and 6000?

Let's start with 5.5k and we can lower it further if needed?

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on c938d3e8b1a4f048cda9727d7aabe8d7e06db758

performance benchmark with full nodes : 6400 TPS, 6200 ms latency, 10500 ms p99 latency,(!) expired 240 out of 2733160 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c938d3e8b1a4f048cda9727d7aabe8d7e06db758

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c938d3e8b1a4f048cda9727d7aabe8d7e06db758 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7367 TPS, 5252 ms latency, 7500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: c938d3e8b1a4f048cda9727d7aabe8d7e06db758
compatibility::simple-validator-upgrade::single-validator-upgrade : 4160 TPS, 10113 ms latency, 13000 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: c938d3e8b1a4f048cda9727d7aabe8d7e06db758
compatibility::simple-validator-upgrade::half-validator-upgrade : 4550 TPS, 8806 ms latency, 12400 ms p99 latency,no expired txns
4. upgrading second batch to new version: c938d3e8b1a4f048cda9727d7aabe8d7e06db758
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6018 TPS, 6481 ms latency, 10600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c938d3e8b1a4f048cda9727d7aabe8d7e06db758 passed
Test Ok

@sitalkedia sitalkedia merged commit 2ecef23 into main Dec 12, 2022
@sitalkedia sitalkedia deleted the forge_perf_criteria branch December 12, 2022 22:57
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants