Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS SDK] use getAccountResource in checkBalance #5860

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

fgfm999
Copy link
Contributor

@fgfm999 fgfm999 commented Dec 12, 2022

Description

Use getAccountResource to replace getAccountResources in CoinClient#checkBalance, which can reduce network load.

Test Plan

pnpm test

Copy link
Contributor

@banool banool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for this!

Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Nice catch!

Can you add a comment on this in the CHANGELOG for unreleased features? https://github.com/aptos-labs/aptos-core/blob/main/ecosystem/typescript/sdk/CHANGELOG.md

We'll attribute it to you in the next release!

@fgfm999
Copy link
Contributor Author

fgfm999 commented Dec 13, 2022

@gregnazario done, PTAL, thanks.

@banool banool enabled auto-merge (squash) December 13, 2022 10:45
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 082489fec0c49d18c64a486a76ff65400fd5c70b

performance benchmark with full nodes : 6119 TPS, 6486 ms latency, 10200 ms p99 latency,(!) expired 720 out of 2613720 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 082489fec0c49d18c64a486a76ff65400fd5c70b

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 082489fec0c49d18c64a486a76ff65400fd5c70b (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7254 TPS, 5324 ms latency, 7100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 082489fec0c49d18c64a486a76ff65400fd5c70b
compatibility::simple-validator-upgrade::single-validator-upgrade : 4724 TPS, 8858 ms latency, 11500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 082489fec0c49d18c64a486a76ff65400fd5c70b
compatibility::simple-validator-upgrade::half-validator-upgrade : 4647 TPS, 8890 ms latency, 11800 ms p99 latency,no expired txns
4. upgrading second batch to new version: 082489fec0c49d18c64a486a76ff65400fd5c70b
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6312 TPS, 6308 ms latency, 11100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 082489fec0c49d18c64a486a76ff65400fd5c70b passed
Test Ok

@banool banool merged commit e32cb5f into aptos-labs:main Dec 13, 2022
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
@fgfm999 fgfm999 deleted the checkBalance branch April 3, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants