-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS SDK] use getAccountResource in checkBalance #5860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Nice catch!
Can you add a comment on this in the CHANGELOG for unreleased features? https://github.com/aptos-labs/aptos-core/blob/main/ecosystem/typescript/sdk/CHANGELOG.md
We'll attribute it to you in the next release!
583f4e5
to
082489f
Compare
@gregnazario done, PTAL, thanks. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Description
Use
getAccountResource
to replacegetAccountResources
inCoinClient#checkBalance
, which can reduce network load.Test Plan