Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS SDK] token client functions to accept optional args #5839

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

0xmaayan
Copy link
Contributor

@0xmaayan 0xmaayan commented Dec 9, 2022

Description

solves the issue with unable to pass in extraArgs for token functions mentioned in #5831

For the simulation part, we will address it in a future PR as it currently doesn't break anything and would like to address it the right way.

Test Plan

tests are passing

@jjleng
Copy link
Contributor

jjleng commented Dec 9, 2022

This PR is good. @leeric92 do you still need token client to give you the payload?

@ericmconnelly
Copy link
Contributor

This PR is good. @leeric92 do you still need token client to give you the payload?

It would be amazing if there's a function I can call to get this payload https://github.com/aptos-labs/aptos-core/blob/main/ecosystem/typescript/sdk/src/token_client.ts#L380

without having to call TransactionPayloadScript

@ericmconnelly ericmconnelly enabled auto-merge (squash) December 9, 2022 08:57
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

✅ Forge suite land_blocking success on 3a7bb1fbe5c037a3f76e0d0c4aae769c422e2eec

performance benchmark with full nodes : 6370 TPS, 6236 ms latency, 10200 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 3a7bb1fbe5c037a3f76e0d0c4aae769c422e2eec

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 3a7bb1fbe5c037a3f76e0d0c4aae769c422e2eec (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7533 TPS, 5130 ms latency, 7100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 3a7bb1fbe5c037a3f76e0d0c4aae769c422e2eec
compatibility::simple-validator-upgrade::single-validator-upgrade : 4525 TPS, 9336 ms latency, 12000 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 3a7bb1fbe5c037a3f76e0d0c4aae769c422e2eec
compatibility::simple-validator-upgrade::half-validator-upgrade : 4612 TPS, 8874 ms latency, 12000 ms p99 latency,no expired txns
4. upgrading second batch to new version: 3a7bb1fbe5c037a3f76e0d0c4aae769c422e2eec
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6350 TPS, 6213 ms latency, 10600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 3a7bb1fbe5c037a3f76e0d0c4aae769c422e2eec passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants