-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Added more specs to the coin
and account
modules
#5832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the ed25519
spec to crypto experts, the rest looks good to me.
e06be9e
to
0a6de5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the specs more modular? (see comments)
2db36f0
to
ac4cff9
Compare
ac4cff9
to
f4f7a60
Compare
f4f7a60
to
5116e62
Compare
- this PR completes many TODOs in the specs of coin and account modules.
5116e62
to
140494c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Alin, I've addressed your comment making the spec more modular. I will move forward and land this for now to unblock the other spec work. However, please let me know if you have a further comment on this. I will be happy to re-iterate it. Thank you so much!
Description
ed25519
andmulti_ed25519
modulestype_info
modulechain_id()
is blocked by the bit operation support.Test Plan
move prove