Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin porting Move Workshop #1 to Aptos.dev #5817

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Begin porting Move Workshop #1 to Aptos.dev #5817

merged 4 commits into from
Dec 13, 2022

Conversation

clay-aptos
Copy link
Contributor

Description

Test Plan

@clay-aptos clay-aptos requested a review from davidiw as a code owner December 7, 2022 23:45
@clay-aptos clay-aptos marked this pull request as draft December 7, 2022 23:45
@clay-aptos clay-aptos linked an issue Dec 7, 2022 that may be closed by this pull request
[Docs] Build out Learning Move section #5774
Closed
@clay-aptos clay-aptos marked this pull request as ready for review December 8, 2022 01:21
@clay-aptos clay-aptos mentioned this pull request Dec 8, 2022
Closed
movekevin
movekevin approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@movekevin movekevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to resolve the TODOs in a separate PR? Would it be weird if they show up on aptos.dev?

@clay-aptos
Copy link
Contributor Author

Are you planning to resolve the TODOs in a separate PR? Would it be weird if they show up on aptos.dev?

Moved to the following issue instead for tracking:
#5774

@clay-aptos clay-aptos marked this pull request as draft December 9, 2022 19:41
@clay-aptos
Copy link
Contributor Author

I want to continue building this out before getting the rest of the team's review. Just want to make sure I'm on the right path. More to come!

@clay-aptos clay-aptos marked this pull request as ready for review December 12, 2022 17:02
@clay-aptos clay-aptos marked this pull request as draft December 13, 2022 18:58
@clay-aptos clay-aptos marked this pull request as ready for review December 13, 2022 19:24
@clay-aptos clay-aptos merged commit 79219d9 into main Dec 13, 2022
@clay-aptos clay-aptos deleted the move-workshop-1 branch December 13, 2022 19:24
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@clay-aptos @areshand
Begin porting Move Workshop aptos-labs#1 to Aptos.dev (aptos-labs#5817)
4f665f2 
* Begin porting Move Workshop aptos-labs#1 to Aptos.dev

* Refine private key step

* Move TODOs to issue for tracking

* Continue building out prerequisites and mint NFT steps

Co-authored-by: Clay Murphy <[email protected]>
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@movekevin movekevin movekevin approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@0xchloe 0xchloe Awaiting requested review from 0xchloe

@cathyaptos cathyaptos Awaiting requested review from cathyaptos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Build out Learning Move section
2 participants
@clay-aptos @movekevin