Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivial: crate name change #5811

Merged
merged 1 commit into from
Dec 8, 2022
Merged

trivial: crate name change #5811

merged 1 commit into from
Dec 8, 2022

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Dec 7, 2022

Description

backup-cli is now aptos-backup-cli and one reference didn't get changed.

Test Plan

@msmouse msmouse requested review from davidiw, movekevin, wrwg and a team as code owners December 7, 2022 21:28
runtian-zhou
runtian-zhou reviewed Dec 7, 2022
View reviewed changes
aptos-move/framework/aptos-framework/doc/voting.md Outdated
@@ -107,8 +107,9 @@ Extra metadata (e.g. description, code url) can be part of the ProposalType stru
Currently, we have three attributes that are used by the voting flow.
1. RESOLVABLE_TIME_METADATA_KEY: this is uesed to record the resolvable time to ensure that resolution has to be done non-atomically.
2. IS_MULTI_STEP_PROPOSAL_KEY: this is used to track if a proposal is single-step or multi-step.
3. IS_MULTI_STEP_PROPOSAL_IN_EXECUTION_KEY: this attribute only exists for and applies to multi-step proposals. The value is used to
indicate if a multi-step proposal is in execution. If yes, we will disable further voting for this multi-step proposal.
3. IS_MULTI_STEP_PROPOSAL_IN_EXECUTION_KEY: this attribute only applies to multi-step proposals. A single-step proposal will not have
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a separate PR for this? Seems irrelevant change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5815

@msmouse msmouse force-pushed the 1207alden-aptos branch 2 times, most recently from 5ae9906 to 319d62e Compare December 7, 2022 23:20
@msmouse msmouse enabled auto-merge (rebase) December 8, 2022 05:39
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

✅ Forge suite land_blocking success on b64fad476e5d9c5347613030a35170188d66caa2

performance benchmark with full nodes : 6846 TPS, 5795 ms latency, 9300 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b64fad476e5d9c5347613030a35170188d66caa2

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b64fad476e5d9c5347613030a35170188d66caa2 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7302 TPS, 5310 ms latency, 7300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: b64fad476e5d9c5347613030a35170188d66caa2
compatibility::simple-validator-upgrade::single-validator-upgrade : 4935 TPS, 8440 ms latency, 11200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: b64fad476e5d9c5347613030a35170188d66caa2
compatibility::simple-validator-upgrade::half-validator-upgrade : 4602 TPS, 9177 ms latency, 11600 ms p99 latency,no expired txns
4. upgrading second batch to new version: b64fad476e5d9c5347613030a35170188d66caa2
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6798 TPS, 5725 ms latency, 10100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b64fad476e5d9c5347613030a35170188d66caa2 passed
Test Ok

@msmouse msmouse merged commit 9f65d10 into main Dec 8, 2022
@msmouse msmouse deleted the 1207alden-aptos branch December 8, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runtian-zhou runtian-zhou runtian-zhou approved these changes

@JoshLind JoshLind JoshLind approved these changes

@grao1991 grao1991 grao1991 approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@movekevin movekevin Awaiting requested review from movekevin

@wrwg wrwg Awaiting requested review from wrwg

@banool banool Awaiting requested review from banool

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msmouse @grao1991 @JoshLind @runtian-zhou