Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resource accounts not dependent on Mint NFT #5805

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Conversation

clay-aptos
Copy link
Contributor

@clay-aptos clay-aptos commented Dec 7, 2022

Description

Addressing:
#5661

Test Plan

@clay-aptos clay-aptos requested a review from davidiw as a code owner December 7, 2022 19:43
@clay-aptos clay-aptos linked an issue Dec 7, 2022 that may be closed by this pull request
Addressing Christian's issue in:
#5672
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@clay-aptos clay-aptos merged commit 5adf300 into main Dec 8, 2022
@clay-aptos clay-aptos deleted the clay-aptos-patch-2 branch December 8, 2022 23:29
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

✅ Forge suite land_blocking success on 01402277d3719c21b926c3c9fcd0bf3aabf4e39a

performance benchmark with full nodes : 6616 TPS, 5999 ms latency, 10300 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 01402277d3719c21b926c3c9fcd0bf3aabf4e39a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 01402277d3719c21b926c3c9fcd0bf3aabf4e39a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7162 TPS, 5354 ms latency, 8100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 01402277d3719c21b926c3c9fcd0bf3aabf4e39a
compatibility::simple-validator-upgrade::single-validator-upgrade : 4691 TPS, 8641 ms latency, 12200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 01402277d3719c21b926c3c9fcd0bf3aabf4e39a
compatibility::simple-validator-upgrade::half-validator-upgrade : 4571 TPS, 8865 ms latency, 11800 ms p99 latency,no expired txns
4. upgrading second batch to new version: 01402277d3719c21b926c3c9fcd0bf3aabf4e39a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6954 TPS, 5536 ms latency, 10400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 01402277d3719c21b926c3c9fcd0bf3aabf4e39a passed
Test Ok

areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
* Make resource accounts not dependent on Mint NFT

* Add clarification from Wolfgang

Addressing Christian's issue in:
aptos-labs#5672
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants