Edit PR #5763 belatedly #5795
Merged
Edit PR #5763 belatedly #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidiw
approved these changes
Dec 7, 2022
developer-docs-site/sidebars.js
Outdated
| @@ -38,13 +38,13 @@ const sidebars = { | |||
| link: { type: "doc", id: "aptos-white-paper/index" }, | |||
| items: ["aptos-white-paper/in-korean"], | |||
| }, | |||
| "guides/basics-life-of-txn", | |||
There was a problem hiding this comment.
this feels a little contentious, why?
There was a problem hiding this comment.
You have renamed this "Aptos Blockchain Deep Dive" so it seems misplaced almost at the bottom of this list. Talk to me.
There was a problem hiding this comment.
For closure, I put the entry back where David located it, 2/3rds of the way down the list in navigation.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
movekevin
approved these changes
Dec 7, 2022
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
* Edit PR aptos-labs#5763 belatedly * Move Aptos Blockchain Deep Dive back down in navigation per reviewer feedback Co-authored-by: Clay Murphy <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan