Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crates] Rename accumulator to aptos-accumulator #5785

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

banool
Copy link
Contributor

@banool banool commented Dec 6, 2022

Description

Just one crate to start with, then I'll start batching these changes. This is part of the plan to name all crates aptos-<name>.

Test Plan

CI.

@banool banool force-pushed the banool/crates_accumulator branch from cb704f9 to 6f9409c Compare December 6, 2022 18:31
Copy link
Contributor

@JoshLind JoshLind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But, wait for the storage folks :P

@JoshLind JoshLind requested a review from grao1991 December 6, 2022 18:56
@banool banool enabled auto-merge (squash) December 6, 2022 19:26
Copy link
Contributor

@msmouse msmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

✅ Forge suite land_blocking success on 6f9409c6ab90aea6fb934dbac292da1160a47b01

performance benchmark with full nodes : 6448 TPS, 6145 ms latency, 10200 ms p99 latency,(!) expired 520 out of 2753900 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 6f9409c6ab90aea6fb934dbac292da1160a47b01

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 6f9409c6ab90aea6fb934dbac292da1160a47b01 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7084 TPS, 5402 ms latency, 8500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 6f9409c6ab90aea6fb934dbac292da1160a47b01
compatibility::simple-validator-upgrade::single-validator-upgrade : 5076 TPS, 7807 ms latency, 10700 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 6f9409c6ab90aea6fb934dbac292da1160a47b01
compatibility::simple-validator-upgrade::half-validator-upgrade : 4798 TPS, 8598 ms latency, 11900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 6f9409c6ab90aea6fb934dbac292da1160a47b01
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6663 TPS, 5825 ms latency, 9900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 6f9409c6ab90aea6fb934dbac292da1160a47b01 passed
Test Ok

@banool banool merged commit c8a5858 into main Dec 6, 2022
@banool banool deleted the banool/crates_accumulator branch December 6, 2022 20:12
areshand pushed a commit to areshand/aptos-core-1 that referenced this pull request Dec 18, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants