[Python] Simulation and other trivial improvements #5770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I verified that the API guarantees to return data and that it won't be optional if it is a successful response
…ansaction This is the default transaction type, this is where folks will look first
verified with an example
this allows folks to customize the internal values for each function without adding bloat. I'll write up a longer task on this so it can be used at a more granular level.
gregnazario
reviewed
Dec 5, 2022
Comment on lines
+37
to
+48
| transaction = rest_client.create_bcs_transaction(alice, TransactionPayload(payload)) | ||
|
|
||
| print("\n=== Simulate before creatng Bob's Account ===") | ||
| output = rest_client.simulate_transaction(transaction, alice) | ||
| assert output[0]["vm_status"] != "Executed successfully", "This shouldn't succeed" | ||
| print(json.dumps(output, indent=4, sort_keys=True)) | ||
|
|
||
| print("\n=== Simulate after creatng Bob's Account ===") | ||
| faucet_client.fund_account(bob.address(), 0) | ||
| output = rest_client.simulate_transaction(transaction, alice) | ||
| assert output[0]["vm_status"] == "Executed successfully", "This should succeed" | ||
| print(json.dumps(output, indent=4, sort_keys=True)) |
There was a problem hiding this comment.
I guess this is the test?
gregnazario
approved these changes
Dec 5, 2022
I'm working on a set of new platform tasks. Some good stuff for some eager folks in the ecosystem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested locally and now with ci/cd!