Fix Python SDK #5769
Merged
Fix Python SDK #5769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Module deserialization was broken * Generic struct deserialization was broken * Improved typing for tests
* mypy is great but the previous individual didn't finish up the work * you can't have a lint that will undoubtedly fail, we use two formatters and they overwrite each other... because of that, we need to use the formatter to detect bad linting or get rid of one of our formatters * verified that the docs page still looks good * updated the faucet for devnet back to the original one
banool
reviewed
Dec 4, 2022
| run-python-examples: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| APTOS_NODE_URL: https://fullnode.devnet.aptoslabs.com |
There was a problem hiding this comment.
I didn't realize the Python SDK was smart enough to add the /v1?
There was a problem hiding this comment.
I think you added that...
| @@ -250,7 +252,7 @@ def transfer(self, sender: Account, recipient: AccountAddress, amount: int) -> s | |||
| } | |||
| return self.submit_transaction(sender, payload) | |||
|
|
|||
| #:!:>bcs_transfer | |||
| # :!:>bcs_transfer | |||
There was a problem hiding this comment.
I think black does this but it breaks the templating into the tutorials, have we double checked that? I think that's why I wasn't using black on the aptos_sdk files in the first place.
banool
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with
make test && make examplesI'm not competent enough to figure out how to integrate with CI/CD