-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform k8s separation #5755
Merged
Merged
terraform k8s separation #5755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustielin
added
the
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
label
Dec 2, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustielin
force-pushed
the
rustielin/terraform-k8s-separation
branch
from
December 7, 2022 17:47
258cc30
to
80251e5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
perryjrandall
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀🚀🚀
✅ Forge suite
|
✅ Forge suite
|
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
* [tf/aws] option to separate k8s workloads from TF state * [tf/gcp] option to separate k8s workloads from TF state
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a variable
manage_via_tf
which allows operators to choose whether to use Terraform to manage their aptos-node (application) deployment, or simply deploy it once (re-deploying on infra changes), but otherwise relying on other toolling such as another k8s client to update the application.The way it works is:
values
blocks are ignored via lifecycle ignore. This prevents re-deploy (or at least a helm re-evaluation) on small changes like irrelevant helm values.set
blocks are conditionally ignored depending on whethermanage_via_tf
is set or not. The type of values set usingset
blocks are those such asimageTag
andera
, which we would expect a re-deployment of the application if we want TF to manage the k8s deploymentTest Plan
Apply while toggling
manage_via_tf
, and observing the TF plan output